(In reply to Ian Moody [:Kwan] (UTC+0) from comment #15)
Is it just me, or has multiple build types on the command line not actually worked since, well, ever as far as I can tell. Not to mention asan-debug not working at all because it has a hyphen in it.
Though you can trick asan-debug into working by replacing the hyphen with a comma. And optionally reversing the words, it isn't fussed.
(In reply to William Lachance (:wlach) (use needinfo!) from comment #17)
(In reply to Ian Moody [:Kwan] (UTC+0) from comment #16)
Anyway, here's a rough WIP that seems to actually work. Even passes the (current) tests. Need to write new ones.
This is looking great, thank you!
Though frankly I'm tempted to rip out any support for users passing in multiple builds (since clearly no-one uses it...), and only keep the internal support for use for the shippable->opt->pgo fallbacking.
It could be that things used to work, but broke when we moved over to taskcluster. I wouldn't be too sad if we lost this feature -- if someone really wants it, they can always re-add it.
Ah, actually part of the problem is that I misread the code/help text and misunderstood what it is for. It was introduced for FxOS which more often had two-part (or more) build types, like "jb-opt", "kk-opt", "1-opt", or even "kk-spark-eng-opt" ("asan-debug" is the only such one these days), and I guess the comma use was intended to save the user worrying about getting the parts in the right order. Given that FxOS has gone away and asan-debug is the only such left, I don't know if there is any value to keeping it around just so a user can do asan,debug (or swapped) instead of asan-debug.