1532595 - Port Bug 1513343 Remove textarea binding and replace usages with html:textarea

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Description

[Jorg K (CEST = GMT+2)]

12:50:24 - Paenglab_work: Bug 1513343 is on autoland and will probably break us. We have a lot of multiline textboxes.
12:52:46 - ntim: Paenglab_work: normally, you should only need to change all usages to textareas and import the context menu scripts if not already done
12:53:53 - ntim: Paenglab_work: if you're using multiline textboxes with spellcheck support then the spellcheck will likely no longer work
12:54:07 - ntim: the spellcheck context menu*

Comment 2

[Magnus Melin [:mkmelin]]

Attachment: bug1532595_textarea_dexbl.patch

This should be it.
Ran out of time, back later in the evening.

The chat changes may be slightly off. Can't test properly since chat is broken atm.

Comment 3

[Richard Marti (:Paenglab)]

Comment on attachment 9048475 [details] [diff] [review]
bug1532595_textarea_dexbl.patch

Review of attachment 9048475 [details] [diff] [review]:
-----------------------------------------------------------------

I give a r+ but the calendar textboxes need some work as they don't flex correctly. The other places look good.

::: calendar/base/content/calendar-task-view.xul
@@ +228,5 @@
>                  </row>
>                </rows>
>              </grid>
>            </hbox>
> +          <html:textarea id="calendar-task-details-description" flex="1"/>

This needs some work as the textbox isn't tall enough.

::: calendar/base/content/dialogs/calendar-summary-dialog.xul
@@ +357,5 @@
>               control="item-description" class="header"/>
>        <separator class="groove" flex="1"/>
>      </hbox>
>      <box orient="horizontal" flex="1">
> +      <html:textarea id="item-description" rows="6" flex="1"/>

Also this textbox isn't wide enough.

Comment 4

[Magnus Melin [:mkmelin]]

Attachment: bug1532595_textarea_dexbl.patch

Some slight update, fixed a textbox.inputField reference

The things you mention are still a bit broken.

Comment 5

[Jorg K (CEST = GMT+2)]

Leaving this open for follow-ups and test fixes, if any.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/994cd1a152ed
Port bug 1513343: Replace usages of textarea binding with html:textarea. r=Paenglab

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/f7f19b653be0
fix linting white-space issues. rs=white-space-only DONTBUILD

Comment 8

[Jorg K (CEST = GMT+2)]

Test failures here in Calendar. Can you get to them before I disable them?

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/5a8945615c42
Fix broken calendar event dialog tests; rs=bustage-fix

Comment 10

[Geoff Lankow (:darktrojan)]

Okay, I fixed the tests, but the event dialog is still wrong visually. I can't get the textbox to flex both horizontally and vertically.

Comment 11

[Jorg K (CEST = GMT+2)]

Thanks, but the tree is still not happy. testTaskView.js is a perma-fail now (bug 1522605?) and on debug runs we see the disconserting:

Assertion failure: IsInAnonymousSubtree(), at z:/build/build/src/dom/base/Element.cpp:1869
PROCESS-CRASH | testTodayPane.js | application crashed [@ mozilla::dom::Element::UnbindFromTree(bool,bool)]

I'll file a bug for that.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/9f7cb4ba09a9
Fix broken calendar task view test; rs=bustage-fix

Comment 13

[Jorg K (CEST = GMT+2)]

Are we done here? No, still more work required, see comment #4.

Comment 14

[Geoff Lankow (:darktrojan)]

Attachment: 1532595-textareas-1.diff

I think this should fix all the remaining issues.

Comment 15

[Richard Marti (:Paenglab)]

Comment on attachment 9051180 [details] [diff] [review]
1532595-textareas-1.diff

Thanks, that fixes it.

I see a little jumping of the textboxes between the three tabs in event. But this isn't caused by you.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/11f46ea9ea72
Fix display of textareas in calendar. r=Paenglab

Comment 17

[Axel Grude]

How would I port a binding like this:

<binding id="inputzombie" extends="chrome://global/content/platformHTMLBindings.xml#inputFields">

it leads to bad coordinates (negative height) in chrome input elements in Tb68b5.

Comment 18

[Magnus Melin [:mkmelin]]

That binding was removed - see bug 1419091. I don't think you can port it directly, but you need to change approach.