1532643 - [wayland] CreateWidgetForPopup() needs widget from parent menu on Wayland

Status: RESOLVED FIXED

(Core :: Layout, enhancement, P2)

Description

[Martin Stránský [:stransky] (ni? me)]

Wayland protocol allows to have only one popup window attached to the parent widget.

Recently we use a toplevel window widget as parent for all popups created by nsMenuPopupFrame::CreateWidgetForView(). That means second level menus (like File -> New Container Tab) are not displayed as both ("File" and "New Container Tab" menus) have the same parent widget.

Comment 1

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532643 - [wayland] Pass parent menu widget to CreateWidgetForPopup() on Wayland, r=bzbarsky

Wayland protocol allows to have only one popup window attached to a parent widget.

Recently we use a toplevel window widget as parent for all popups created
by nsMenuPopupFrame::CreateWidgetForView(). That means a second level menu
(like File -> New Container Tab) is not displayed as both
("File" and "New Container Tab" menus) have the same parent widget.

As a solution pass near parent menu widget to CreateWidgetForPopup()
to allow toolkit to create correct popup hierarchy at tooklit level.

Comment 2

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8d6c96b9623b121e03f5841982f687c873140373

Comment 3

[Martin Stránský [:stransky] (ni? me)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=20d68aa8ce842845e5e697e3e5ff5043de520bdd

Comment 4

[Pascal Chevrel:pascalc]

Marking as wontfix for 67 as Wayland support won't ship in that release.

Comment 5

[Martin Stránský [:stransky] (ni? me)]

Neil, can you be please more concrete which menus/popups needs to be covered? I tried various popups/menus and everything works fine. I tried bookmarks library and all menus also work fine there (popups, menus...). Thanks.

Comment 6

[Neil Deakin]

There are lots of places where a context menu can be opened while another menu is open. For example, open a bookmark folder on the bookmarks toolbar, which will open as a menu, then open a context menu for a specific bookmark. Tooltips also are assigned for each bookmark item since labels can be cropped.

The context menu or tooltips, or the dropdowns of <select> elements can also be opened for any panel that opens from an extension.

Comment 7

[Martin Stránský [:stransky] (ni? me)]

(In reply to Neil Deakin (away march 22 - 31) from comment #6)

There are lots of places where a context menu can be opened while another
menu is open. For example, open a bookmark folder on the bookmarks toolbar,
which will open as a menu, then open a context menu for a specific bookmark.
Tooltips also are assigned for each bookmark item since labels can be
cropped.

The context menu or tooltips, or the dropdowns of <select> elements can also
be opened for any panel that opens from an extension.

Yes, I think I understand you now.

The content menus created/opened when a different menu is active is a different case and needs an extra approach. One content menu can have different parents as it's reused and that needs to be addressed when the popup is rendered and not when it's created.

Comment 8

[Martin Stránský [:stransky] (ni? me)]

Attachment: Bug 1532643 - [Wayland] Set popup window hierarchy run-time on Wayland for menus in the same frame hierarchy, r=NeilDeakin

Wayland protocol allows to have only one popup window attached to a parent widget.

Recently we use a toplevel window widget as parent for all popups.
That means a second level menu (like File -> New Container Tab)
is not displayed as both ("File" and "New Container Tab" menus)
have the same parent widget.

As a solution allow to get the actual parent run-time and set that
when we open the window on toolkit level.

This patch covers menu widgets in the same frame hierarchy.

Comment 9

[Martin Stránský [:stransky] (ni? me)]

Fro the widgets in different frame hierarchy we need to use run-time popup tracking as we have in Bug 1539471, so I'll extend Bug 1539471 for it.

Comment 10

[Martin Stránský [:stransky] (ni? me)]

Ping. Neil, any update about the review? It's blocking all further wayland popup fixes. Thanks.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b9a9068783f7
[Wayland] Set popup window hierarchy run-time on Wayland for menus in the same frame hierarchy, r=NeilDeakin

Comment 12

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/b9a9068783f7