Cranelift: Provide source locations for symbolic accesses
Categories
(Core :: JavaScript: WebAssembly, enhancement, P3)
Tracking
()
People
(Reporter: bbouvier, Unassigned)
References
Details
See also https://searchfox.org/mozilla-central/source/js/src/wasm/cranelift/src/baldrapi.rs#94 which doesn't set the srcLoc.
|
Reporter | |
Comment 1•5 years ago
|
||
My understanding is that it can't be done at the moment, since Cranelift calls the reloc_ functions at binemit time. What we could do is have Cranelift provide the source locations when it calls these functions, that is, add SourceLocation parameters to the CodeSink::reloc_ functions. Does it make sense Dan?
|
|
Reporter | |
Comment 2•5 years ago
|
||
Another possibility would be to get the source location from the Cursor when we're calling symbolic_funcref (in baldrdash), and encode it in the namespace (1 bit to know if it's a user defined function or a symbolic function, the rest for the source location in the case of a symbolic function), but that's less elegant (and wouldn't apply to other Cranelift embedders).
|
||
Updated•5 years ago
|
|
|
Reporter | |
Comment 3•4 years ago
|
||
Will do this as part of bug 1618595.
Description
•