1618595 - Cranelift: update Baldrdash for new isel backend

Status: RESOLVED FIXED

(Core :: JavaScript: WebAssembly, enhancement, P3)

Description

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: wip.patch

I'm just posting a WIP patch here, to be completed as we implement more instructions in the new Cranelift isel backend.

Comment 2

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: wip.patch

Comment 3

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: folded-wip.patch

This is the previous wip patch, plus all the patches from dependencies, folded altogether.

Comment 4

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: wip.patch

Comment 5

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1618595: Support Cranelift's new codegen backend in Baldrdash; r?cfallin

Comment 6

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: folded-for-testing.patch

A few patches, folded together for testing purposes:

1. import this patch in your spidermonkey fork
2. make sure to checkout a recent version of Chris' fork of wasmtime
3. follow the steps in https://github.com/bytecodealliance/cranelift/wiki/Spidermonkey#using-a-local-cranelift-fork-in-spidermonkey to point to the fork of wasmtime.

Comment 7

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1618595: Disable Cranelift on aarch64 when reftypes are enabled; r?lth

This requires adding a new JSOptions field (for internal use within the shell),
as well as a new browser pref (to support possible Cranelift benchmarking on
aarch64).

Comment 8

[Benjamin Bouvier [:bbouvier] (inactive)]

Try build, with Cranelift bump (we can't do it yet because wasmtime has a few overly large files):
https://treeherder.mozilla.org/#/jobs?repo=try&revision=84fe59490627313483f4b73171e7200c96d693c3

Comment 9

[Benjamin Bouvier [:bbouvier] (inactive)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=8dd00dc5b3651f9d9526e9487a1931b3e3ef1833 with arm32 fixed + vendored files split

Comment 10

[Benjamin Bouvier [:bbouvier] (inactive)]

Attachment: Bug 1618595 - Bump Cranelift to b7cfd39b531680217537cfcf5294a22077a0a58d; r?jseward

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c34adf867751
Bump Cranelift to b7cfd39b531680217537cfcf5294a22077a0a58d; r=jseward
https://hg.mozilla.org/integration/autoland/rev/8ca39ea654b4
Support Cranelift's new codegen backend in Baldrdash; r=cfallin
https://hg.mozilla.org/integration/autoland/rev/50cce8fd017c
Disable Cranelift on aarch64 when reftypes are enabled; r=lth,perftest-reviewers,sparky

Comment 12

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c34adf867751
https://hg.mozilla.org/mozilla-central/rev/8ca39ea654b4
https://hg.mozilla.org/mozilla-central/rev/50cce8fd017c