153272 - Can't drag a link to the bookmarks menu on the personal toolbar

Status: RESOLVED FIXED

(SeaMonkey :: Bookmarks & History, defect)

Description

[Koike Kazuhiko]

Can't drag a link to the bookmarks menu on the personal toolbar.

If you drag a link to [bookmarks] on the personal toolbar,
the bookmarks menu opens. But it closes if you try to drop.

Comment 1

[Cees T.]

On WinME with trunk build 2002062008, the folders don't open at all! (Well, in
about 5% of the cases, unable to steadily reproduce.)

Even though DND bookmarking worked fine in trunk 2002060808, I'm gonna try what
Pierre Chanial suggests in bug 139471, comment 41.

This is a major (regressed?) usability problem if you don't use the sidebar to
bookmark.

Comment 2

[Cees T.]

Woo! I fixed a bug!
In navigatorDD.js (in comm.jar), I changed:

  isTimerSupported: navigator.platform.indexOf("Win") == -1 &&
navigator.platform.indexOf("Mac") == -1,

to:

  isTimerSupported: true, // navigator.platform.indexOf("Win") == -1 &&
navigator.platform.indexOf("Mac") == -1,

I doubt this is cross plaform, but it WFM on WinME ^_^

Comment 3

[timeless]

javascript: [navigator.platform, navigator.platform.indexOf("Win"), 
navigator.platform.indexOf("Mac"), Boolean(navigator.platform.indexOf("Win") && 
navigator.platform.indexOf("Mac"))]

Win32,0,-1,false

Comment 4

[Pierre Chanial]

It seems like timers fire again on Windows during DND. That's good.
Thank you very much for your testing, CT. I will dl a Win trunk build and will
attach a patch that works for the Windows platform.
I guess that Mac builds are not affected. Could anybody confirm?

Comment 5

[Pierre Chanial]

Attachment: Patch v1.0

I confirm that we can now use timers during DND again on Windows!
The patch sets isTimerSupported to true for the Windows platform, as CT did.
I've left isTimerSupported to false for Mac. If I can get some qa on Mac, and
if the pb also occurs, let's open a new bug: a cleanup will be necessary to
remove all the isTimerSupported instances

Note that this patch will make bug 150348 more visible on Windows.
In some cases, menus will not close after the drop, since dragexit events don't
always fire.

Comment 6

[Pierre Chanial]

Pinkerton confirmed me that for Carbon builds, timers are still not fired during
DND. This patch is therefore final. requesting r= and sr=

Comment 7

[Blake Ross]

Comment on attachment 89268 [details] [diff] [review]
Patch v1.0

sr=blake

Comment 8

[Pierre Chanial]

patch checked in by timeless.