1532790 - Custom Element editable menulist doesn't accept selection of dropdown items

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Geoff Lankow (:darktrojan)]

From bug 1524457 comment 68.

Comment 1

[Geoff Lankow (:darktrojan)]

Attachment: 1532790-menulist-test-1.diff

The menulist was accepting the dropdown item, but not updating to reflect its new value.

Comment 2

[Magnus Melin [:mkmelin]]

Comment on attachment 9049104 [details] [diff] [review]
1532790-menulist-test-1.diff

Review of attachment 9049104 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin with the below explained or fixed

::: mail/base/content/mailWidgets.js
@@ +510,5 @@
> +        event.stopPropagation();
> +        this.selectedItem = null;
> +        this.setAttribute("value", this._inputField.value);
> +        this.dispatchEvent(new CustomEvent("change", { bubbles: true }));
> +      };

why first stopPropagation just to dispatch the same event again?

Comment 3

[Geoff Lankow (:darktrojan)]

So that the target of the event is the menulist and not the input field inside it. The internals of a widget should be a black box to anything outside it. It isn't in a lot of cases, but it should be.

Comment 4

[Magnus Melin [:mkmelin]]

Ah right, perhaps add a comment in the code

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/de90669821c5
Fix editable menulist to accept selection of dropdown items; r=mkmelin

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/2abcf2279b72
Add missing getter to match overloaded setter; rs=bustage-fix DONTBUILD

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/53e9bb2729c2
Skip test on Mac where it will never pass; rs=bustage-fix

Comment 8

[Geoff Lankow (:darktrojan)]

Gah, this broke date/time pickers!