1532863 - Contextmenu of keyword search field background-color is transparent

Status: VERIFIED FIXED

(Toolkit :: UI Widgets, defect, P1)

Description

[Alice0775 White]

Attachment: image.png

Reproducible: always

Steps to reproduce:

1. Open about:preferences > Search
2. Attempt to edit keyword search
3. Right click on the keyword editing field

Actual Results:
Contextmenu background is transparent. See attached screenshot

Comment 1

[Alice0775 White]

Regression window:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1657fe18be9bc445c7838e3b4e93a9bfc4f85e7f&tochange=a6606e85276716b93695029cb914a678beb51708

Regressed by:
a6606e852767 Victor Porof — Bug 1523957 - Convert trees to custom elements, r=bgrins, mak, standard8, MattN

Victor,
Your patch seems to cause the regression. Can you please look into this?

Comment 2

[Victor Porof [:vporof][:vp]]

Will do, thanks!

Keeping ni?.

Comment 3

[:Gijs (he/him)]

[Tracking Requested - why for this release]:
Usability regression in nightly that we shouldn't ship.

Comment 4

[Pascal Chevrel:pascalc]

Victor, are you working on this bug and should it be moved to Toolkit::XUL Widgets since this was regressed by Bug 1523957? This is a P1 tracked regression for 67 and we should probably fix that as soon as possible. Thanks

Comment 5

[Itiel]

Another STR:

1. Click star in the URL bar to add a bookmark
2. Click down arrow next to folder dropdown
3. Click New Folder
4. Right click the selected "New Folder" text

Comment 6

[Victor Porof [:vporof][:vp]]

Having a closer look asap!

Comment 7

[Victor Porof [:vporof][:vp]]

Attachment: Bug 1532863 - Contextmenu of keyword search field background-color is transparent, r=mossop

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/72c8227148dd
Contextmenu of keyword search field background-color is transparent, r=mossop

Comment 9

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/72c8227148dd

Comment 10

[Itiel]

Fixed on latest Nightly.