1533739 - The One-Click Search Engines section is re-arranged when the keyword input is displayed

Status: RESOLVED DUPLICATE of bug 1532863

(Firefox :: Settings UI, defect, P1)

Description

[Gyula Palko[:gpalko]]

Affected versions

• Nightly 67.0a1 (20190305214137)

Affected platforms

• Linux/Ubuntu

Steps to reproduce

1. Launch Firefox Nightly
2. Open about:preferences#search
3. Double click the Keyword section from One Click Search Engines list

Expected result

• Text input field is displayed and the width of the table is not modified

Actual result

• The One-Click Search Engines section is re-arranged when the keyword input is displayed

Regression window
I'll update this with regression range ASAP

Comment 1

[Mike de Boer [:mikedeboer]]

I wouldn't be surprised if this has something to do with the work done to move from global stylesheets to document stylesheets...

Comment 2

[Jared Wein [:jaws] (please needinfo? me)]

Gyula, were you able to find the regression range?

Comment 3

[Gyula Palko[:gpalko]]

(In reply to Gyula Palko from comment #0)

Affected versions

• Nightly 67.0a1 (20190305214137)

Affected platforms

• Linux/Ubuntu

Steps to reproduce

1. Launch Firefox Nightly
2. Open about:preferences#search
3. Double click the Keyword section from One Click Search Engines list

Expected result

• Text input field is displayed and the width of the table is not modified

Actual result

• The One-Click Search Engines section is re-arranged when the keyword input
  is displayed

Regression window
I'll update this with regression range ASAP

Last good revision: 1657fe18be9bc445c7838e3b4e93a9bfc4f85e7f
First bad revision: a6606e85276716b93695029cb914a678beb51708
Pushlog: https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=1657fe18be9bc445c7838e3b4e93a9bfc4f85e7f&tochange=a6606e85276716b93695029cb914a678beb51708

Note
Not reproducible on Windows and MacOS

Comment 4

[Neha Kochar [:neha]]

Victor, the pushlog (comment 3) points to your patch. Can you please look into this for 67 regression?

Comment 5

[Victor Porof [:vporof][:vp]]

On it.

Comment 6

[Pascal Chevrel:pascalc]

Victor, can we get an update on this bug? (Also note that since 67 has now moved to beta, patches will require an uplift to the beta branch after landing on mozilla-central) Thanks

Comment 7

[Victor Porof [:vporof][:vp]]

Currently on PTO and back on Apr 1, this will be a top priority fix as soon as I get back. If there's more urgency to fix before then, please let me know.

Comment 8

[Pascal Chevrel:pascalc]

(In reply to Victor Porof [:vporof][:vp] from comment #7)

Currently on PTO and back on Apr 1, this will be a top priority fix as soon as I get back. If there's more urgency to fix before then, please let me know.

This should be fine, thanks.

Comment 9

[Neha Kochar [:neha]]

Victor, could you please provide an estimate timeline for the patch so we can assess if that will work for the beta 67 uplift or not?

Comment 10

[Victor Porof [:vporof][:vp]]

Today/ tomorrow.

Comment 11

[Victor Porof [:vporof][:vp]]

Attachment: Screenshot 2019-04-08 at 09.00.34.png

I've done everything I can to try to reproduce this issue, but haven't been able to. I suspect I've fixed this already a few weeks ago with https://hg.mozilla.org/mozilla-central/rev/72c8227148dd in bug 1532863.

Can you please confirm?

Comment 12

[Gyula Palko[:gpalko]]

I can't reproduce this on the latest Nightly builds, I've checked with mozregression and I can confirm, that it was fixed by bug 1532863

Comment 13

[Pascal Chevrel:pascalc]

Thanks, marking as a duplicate then.