Open Bug 1533170 Opened 6 years ago Updated 2 years ago

Referrer should come from somewhere instead of hardcoded

Categories

(Firefox :: New Tab Page, enhancement, P3)

Product:
Firefox
Component:
New Tab Page
Type:
enhancement

Tracking

()

Tracking Flags:
Tracking Status
firefox66 --- wontfix

People

(Reporter: Mardak, Unassigned)

References

Details

Bug 1533089 ended up hardcoding the value into SafeAnchor and DSLinkMenu but perhaps they should be from the feed as noted in https://github.com/mozilla/activity-stream/pull/4832#discussion_r263163400

Previously, TopStoriesFeed included "https://getpocket.com/recommendations" in the json options browser.newtabpage.activity-stream.feeds.section.topstories.options that allowed normandy pref changes to specify a different value (although unclear if this was ever changed).

status-firefox66: --- → wontfix
Iteration: --- → 68.1 - Mar 18 - 31
Priority: -- → P1

We need some information about whether this is necessary, Nick can you advise

Flags: needinfo?(nchapman)
Keywords: uiwanted
Iteration: 68.1 - Mar 18 - 31 → 68.2 - Apr 1 - 14
Keywords: uiwanted
No longer blocks: 1512725

Nick to chime in, but ok to punt to 69.

Priority: P1 → P2
Iteration: 68.2 - Apr 1 - 14 → ---
Blocks: pocket-newtab-69
No longer blocks: pocket-newtab-69
No longer blocks: pocket-newtab-68
Assignee: nobody → edilee
Iteration: --- → 69.1 - May 13 - 26
Priority: P2 → P1

kanhema, previously top stories allowed customizing the referrer based on the pref I believe primarily because topstories was implemented to be generic allowing any stories provider thus needing some way to configure what the url goes to. Do we need to restore this behavior of being able to change the referrer url as part of the pref, e.g., when running an experiment?

Flags: needinfo?(nchapman) → needinfo?(tkanhema)

Checking, will revert shortly.

Flags: needinfo?(tkanhema)
Iteration: 69.1 - May 13 - 26 → 69.2 - May 27 - Jun 9
Flags: needinfo?(tkanhema)
Iteration: 69.2 - May 27 - Jun 9 → 69.3 - Jun 10 - 23
Component: Activity Streams: Newtab → New Tab Page

P3 until the use case is needed. Right now everything is okay being from the referrer: https://getpocket.com/recommendations

Assignee: edilee → nobody
Iteration: 69.3 - Jun 10 - 23 → ---
Priority: P1 → P3
Flags: needinfo?(tkanhema)
No longer blocks: pocket-newtab
Severity: normal → S3
You need to log in before you can comment on or make changes to this bug.