1533391 - Lint Debugger on try

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement, P3)

Description

[Jason Laster [:jlast]]

We should run yarn lint in the try test so that our JS, CSS, and MD is linted.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1533391 - Lint Debugger on try. r=dwalsh

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5d5db39b0497
Lint Debugger on try. r=davidwalsh

Comment 3

[Natalia Csoregi [:nataliaCs]]

Backed out for debugger failures

backout: https://hg.mozilla.org/integration/autoland/rev/c84fd846abe142b628e1c8bcd2144c7c4f21983c

push: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=5d5db39b04977e9095ecc25bb66d5438010d0cf0&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29

failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=232744085&repo=autoland

[task 2019-03-08T20:21:28.787Z]
[task 2019-03-08T20:21:28.787Z] Oops! Something went wrong! :(
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] ESLint: 5.9.0.
[task 2019-03-08T20:21:28.788Z] ESLint couldn't find the plugin "eslint-plugin-no-unsanitized". This can happen for a couple different reasons:
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] 1. If ESLint is installed globally, then make sure eslint-plugin-no-unsanitized is also installed globally. A globally-installed ESLint cannot find a locally-installed plugin.
[task 2019-03-08T20:21:28.788Z]
[task 2019-03-08T20:21:28.788Z] 2. If ESLint is installed locally, then it's likely that the plugin isn't installed correctly. Try reinstalling by running the following:
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] npm i eslint-plugin-no-unsanitized@latest --save-dev
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] Path to ESLint package: /builds/worker/checkouts/gecko/devtools/client/debugger/new/node_modules/eslint
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.789Z] If you still can't figure out the problem, please stop by https://gitter.im/eslint/eslint to chat with the team.
[task 2019-03-08T20:21:28.789Z]
[task 2019-03-08T20:21:28.855Z] error Command failed with exit code 2.
[task 2019-03-08T20:21:28.855Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.911Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.911Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.911Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.911Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:28.921Z] error Command failed with signal "SIGTERM".
[task 2019-03-08T20:21:28.921Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[task 2019-03-08T20:21:29.278Z] ERROR: "lint:js" exited with 1.
[task 2019-03-08T20:21:29.283Z] error Command failed with exit code 1.
[task 2019-03-08T20:21:29.283Z] info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
[taskcluster 2019-03-08 20:21:29.936Z] === Task Finished ===
[taskcluster 2019-03-08 20:21:29.936Z] Unsuccessful task run with exit code: 1 completed in 713.376 seconds

Comment 4

[Jason Laster [:jlast]]

sorry about that.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/423f48c98230
Lint Debugger on try. r=davidwalsh

Comment 6

[Andreea Pavel [:apavel]]

Backed out for failing try test

Push with failure https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=423f48c9823088ca50cb00d88dd78c4046b1f054&selectedJob=233113900

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233113900&repo=autoland&lineNumber=373

Backout: https://hg.mozilla.org/integration/autoland/rev/ee2473319e97f98373b68151353b4de5e2cfc2c3

Comment 7

[Andrew Halberstadt [:ahal]]

Hm, I can't reproduce this locally. This is probably the tests fault rather than the change. Maybe we should disable the test while I try to figure this out.

I'll run a few try pushes to see if I can reproduce.

Comment 8

[Andrew Halberstadt [:ahal]]

I think the test is intermittent (if you look at jlast's push there were two passes and two failures) and is likely unrelated to his changes. This test only runs when specific files are modified, which might explain why this failure hasn't shown up before.

I'm looking into why it's intermittent now. Obviously a 50% pass rate isn't acceptable so I'm fine if we disable the test in the meantime.

Comment 9

[Andrew Halberstadt [:ahal]]

I'll track fixing this test in bug 1534375.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/68834c8b15bd
Lint Debugger on try. r=davidwalsh

Comment 11

[Andrew Halberstadt [:ahal]]

I've confirmed that this test fails on vanilla mozilla-central as well, so please don't backout the above push if it happens again. I think I have a handle on the problem over in bug 1534375.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ded300544a9
Lint Debugger on try.

Comment 13

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/68834c8b15bd
https://hg.mozilla.org/mozilla-central/rev/6ded300544a9