1533445 - Android test cleanup takes too long to time out when device unresponsive

Status: RESOLVED FIXED

(Firefox for Android Graveyard :: Testing, defect)

Description

[Geoff Brown [:gbrown]]

In bug 1532435, there are recent examples of tasks exceeding their max-run-time after multiple 5 minute adb timeouts.

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232261308&repo=autoland&lineNumber=1862
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232339480&repo=mozilla-inbound&lineNumber=3605
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=232414336&repo=autoland&lineNumber=1912

Since max-run-time is exceeded, logcats and other diagnostics are lost, which makes it hard to determine what caused the original problem.

It also wastes test time.

I want to reduce timeouts during shutdown and/or avoid additional device interaction after adb timeouts.

Comment 1

[Bob Clary [:bc] (inactive)]

I think that once we get an ADBTimeoutError we should quit trying to run the test and exit as soon as possible. It would be great if we could just catch ADBTimeoutError at the top level of the scripts running the test, emit a generic "device disconnected" or something error the sheriffs could use to classify all of the ADBTimeoutError failures to a single bug.

Comment 2

[Geoff Brown [:gbrown]]

You basically did that in bug 1477807! That's working fine for many cases, like in

https://taskcluster-artifacts.net/N3Zub3eWRzWePNJKZx1xeQ/0/public/logs/live_backing.log

Comment 3

[Geoff Brown [:gbrown]]

ANR/tombstone checks introduced in bug 1531611 are part of the problem.

Comment 4

[Geoff Brown [:gbrown]]

Attachment: Bug 1533445 - Make android tests shutdown faster when device unresponsive; r=bc

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3fd4a7b0872e
Make android tests shutdown faster when device unresponsive; r=bc

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/3fd4a7b0872e