1533519 - Allow in private windows checkbox should only appear for full extensions

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P1)

Description

[Mark Striemer [:mstriemer]]

STR

1. Open about:addons
2. Go to Get Add-ons
3. Click + Add to Firefox for a static theme

Expected result: Theme is installed and the confirmation notification is shown without the "allow in private windows" checkbox
Actual result: The "allow in private windows" checkbox is shown

Bonus issue: checking the allow in private windows checkbox then confirming the dialog will disable the theme. I assume hiding the checkbox is enough to disregard this.

STR

1. Open about:addons
2. Go to Get Add-ons
3. Click + Add to Firefox for a static theme
4. Check Allow this extension to run in Private Windows
5. Click Okay, Got It

Expected result: The theme is enabled in private windows
Actual result: The theme is now disabled

Comment 1

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1533519 hide private checkbox for non-extension addons

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/42193ad4cde7
hide private checkbox for non-extension addons r=rpl

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/42193ad4cde7

Comment 4

[CosminB]

Attachment: Bug1533519.gif

I can still reproduce this issue on Firefox 67.0a1 (20190312095443) under Win 7 64-bit and Mac OS X 10.14.1:

STR:

• Open normal window.
• Open private window.
• From normal window, install a static theme.
• Check the private window, for the install confirmation pop-up.

Comment 5

[CosminB]

Attachment: Bug1533519.gif

Comment 6

[Shane Caraveo (:mixedpuppy)]

comment 4 fixed in bug 1534714

Comment 7

[CosminB]

Attachment: Bug1533519.gif

This issue is verified as fixed on Firefox 68.0a1 (20190320112939) and 67.0b3 (20190318154932) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.