Closed Bug 1533519 Opened 7 months ago Closed 7 months ago

Allow in private windows checkbox should only appear for full extensions

Categories

(WebExtensions :: Frontend, defect, P1)

defect

Tracking

(firefox67 verified, firefox68 verified)

VERIFIED FIXED
mozilla67
Tracking Status
firefox67 --- verified
firefox68 --- verified

People

(Reporter: mstriemer, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(4 files)

STR

  1. Open about:addons
  2. Go to Get Add-ons
  3. Click + Add to Firefox for a static theme

Expected result: Theme is installed and the confirmation notification is shown without the "allow in private windows" checkbox
Actual result: The "allow in private windows" checkbox is shown

Bonus issue: checking the allow in private windows checkbox then confirming the dialog will disable the theme. I assume hiding the checkbox is enough to disregard this.

STR

  1. Open about:addons
  2. Go to Get Add-ons
  3. Click + Add to Firefox for a static theme
  4. Check Allow this extension to run in Private Windows
  5. Click Okay, Got It

Expected result: The theme is enabled in private windows
Actual result: The theme is now disabled

Summary: Allow in private windows checkbox should be hidden for staticthemes → Allow in private windows checkbox should only appear for full extensions
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/42193ad4cde7
hide private checkbox for non-extension addons r=rpl
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Attached image Bug1533519.gif

I can still reproduce this issue on Firefox 67.0a1 (20190312095443) under Win 7 64-bit and Mac OS X 10.14.1:

STR:

  • Open normal window.
  • Open private window.
  • From normal window, install a static theme.
  • Check the private window, for the install confirmation pop-up.
Flags: needinfo?(mixedpuppy)
Attached image Bug1533519.gif
Depends on: 1534714
Flags: needinfo?(mixedpuppy)
Attached image Bug1533519.gif

This issue is verified as fixed on Firefox 68.0a1 (20190320112939) and 67.0b3 (20190318154932) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached video.

Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.