1533571 - Generated breakpoint position does not logically correspond with original location

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Logan Smyth [:loganfsmyth]]

Copying from https://github.com/firefox-devtools/debugger/issues/8093

These steps are pretty much the same as https://github.com/firefox-devtools/debugger/issues/8092
Steps:

1. Open Editor/Tabs.js
2. Find the line in updateHiddenTabs that has hiddenTabs.find(tab => tab.id == selectedSource.id)
3. Click to add a breakpoint
4. If https://github.com/firefox-devtools/debugger/issues/8092 has not been fixed, add a second breakpoint on hiddenTabs and delete the one on find
5. Go to the generated file and view this breakpoint

AR:
There is a breakpoint on hiddenTabs that actually maps to the return value breakpoint of the function in the generated code.

ER:
There probably just shouldn't be a breakpoint there at all.

Comment 1

[Logan Smyth [:loganfsmyth]]

Attachment: Bug 1533571 - Do not mark the return opcode as breakable for expression-body arrow functions. r=jlast

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ea20a62a2fa0
Do not mark the return opcode as breakable for expression-body arrow functions. r=jlast

Comment 3

[Dorel Luca [:dluca]]

https://hg.mozilla.org/mozilla-central/rev/ea20a62a2fa0