Closed Bug 1533813 Opened 1 year ago Closed 1 year ago

getOriginalLocation can be expensive

Categories

(DevTools :: Debugger, enhancement)

enhancement
Not set
normal

Tracking

(firefox67 fixed)

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: jlast, Unassigned)

References

Details

Attachments

(1 file)

there are 80K generated breakpoint positions in debugger.js using the flush/task strategy can use a lot of resources.

doing one invoke for getOriginalLocations is much cheaper.

Just saw this in my (500 line app code) nextjs/typescript app, where it took 5+sec to load the breakpoints (which doesn't have a loading indicator, so is very opaque): https://perfht.ml/2CdhaEu

Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/985e05a4b540
getOriginalLocation can be expensive. r=loganfsmyth
Pushed by lsmyth@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/0d55cac5f346
getOriginalLocation can be expensive. r=loganfsmyth
Status: NEW → RESOLVED
Closed: 1 year ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Flags: needinfo?(jlaster)
You need to log in before you can comment on or make changes to this bug.