1533813 - getOriginalLocation can be expensive

Status: RESOLVED FIXED

(DevTools :: Debugger, enhancement)

Description

[Jason Laster [:jlast]]

there are 80K generated breakpoint positions in debugger.js using the flush/task strategy can use a lot of resources.

doing one invoke for getOriginalLocations is much cheaper.

Comment 1

[Jason Laster [:jlast]]

Attachment: Bug 1533813 - getOriginalLocation can be expensive. r=loganfsmyth

Comment 2

[:Harald Kirschner :digitarald]

Just saw this in my (500 line app code) nextjs/typescript app, where it took 5+sec to load the breakpoints (which doesn't have a loading indicator, so is very opaque): https://perfht.ml/2CdhaEu

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/985e05a4b540
getOriginalLocation can be expensive. r=loganfsmyth

Comment 4

[Dorel Luca [:dluca]]

Backed out changeset 985e05a4b540 (bug 1533813) for Debugger failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#?job_id=233253485&repo=autoland

Push with failure:
https://treeherder.mozilla.org/#/jobs?repo=autoland&selectedJob=233218358&revision=985e05a4b54024ae40be6d94aaf8d9fb3d66f9b2

Backout:
https://hg.mozilla.org/integration/autoland/rev/02b387ef172ee8e00ba33eb630def6cb0784b05b

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0d55cac5f346
getOriginalLocation can be expensive. r=loganfsmyth

Comment 6

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/0d55cac5f346