Remove the closing period in the "Allow this extension to run in Private Windows." string

VERIFIED FIXED in Firefox 67

Status

enhancement
P1
normal
VERIFIED FIXED
3 months ago
2 months ago

People

(Reporter: itiel_yn8, Assigned: mixedpuppy)

Tracking

(Blocks 1 bug)

unspecified
mozilla67
Dependency tree / graph

Firefox Tracking Flags

(firefox67 verified)

Details

Attachments

(2 attachments)

Reporter

Description

3 months ago

See bug 1527127 comment 26.
This string represents a checkbox, and should not have a trailing period.

https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#1136

Meridel, not sure if you did the copy for this feature, can you double check (or redirect)?

Flags: needinfo?(mwalkington)
Assignee

Updated

2 months ago
Assignee: nobody → mixedpuppy
Priority: -- → P1

Comment 3

2 months ago

Is this the post install door hanger? No period after string. Also no period after "Learn more"—if we have one there (I don't see a visual here).

Flags: needinfo?(mwalkington)
Assignee

Comment 4

2 months ago

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

Comment 5

2 months ago

Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?

Flags: needinfo?(mixedpuppy)

Comment 6

2 months ago
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/364ed778d761
remove period from checkbox description r=flod,mstriemer
Assignee

Comment 7

2 months ago

(In reply to Meridel from comment #5)

Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?

We discussed it, getting the right alignments with xul/dtd had issues. We'll add it in the future.

Flags: needinfo?(mixedpuppy)

Comment 8

2 months ago

Sounds good, thank you.

Comment 9

2 months ago

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).

Assignee

Comment 10

2 months ago

(In reply to Ton [:Tonnes] from comment #9)

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).

That should have been a new bug, not a comment on a bug. It got missed.

Comment 11

2 months ago
bugherder
Status: NEW → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

Comment 12

2 months ago
Posted image Bug1534131.png

This issue is verified as fixed on Firefox 67.0a1 (20190312095443) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.

Updated

2 months ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.