1534131 - Remove the closing period in the "Allow this extension to run in Private Windows." string

Status: VERIFIED FIXED

(WebExtensions :: General, enhancement, P1)

Description

[Itiel]

See bug 1527127 comment 26.
This string represents a checkbox, and should not have a trailing period.

https://searchfox.org/mozilla-central/source/browser/locales/en-US/chrome/browser/browser.dtd#1136

Comment 1

[Francesco Lodolo [:flod]]

Meridel, not sure if you did the copy for this feature, can you double check (or redirect)?

Comment 2

[Shane Caraveo (:mixedpuppy)]

Attachment: Bug 1534131 remove period from checkbox description

Comment 3

[Meridel [:meridel]]

Is this the post install door hanger? No period after string. Also no period after "Learn more"—if we have one there (I don't see a visual here).

Comment 4

[Shane Caraveo (:mixedpuppy)]

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

Comment 5

[Meridel [:meridel]]

Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/364ed778d761
remove period from checkbox description r=flod,mstriemer

Comment 7

[Shane Caraveo (:mixedpuppy)]

(In reply to Meridel from comment #5)

Aha, thank you. The plan was to include a link to the SUMO article in this panel. Not possible?

We discussed it, getting the right alignments with xul/dtd had issues. We'll add it in the future.

Comment 8

[Meridel [:meridel]]

Sounds good, thank you.

Comment 9

[Ton [:Tonnes]]

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).

Comment 10

[Shane Caraveo (:mixedpuppy)]

(In reply to Ton [:Tonnes] from comment #9)

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

There is no "learn more" on this panel. You can see the panel in attachment 9045294 [details].

However, both "Learn how to manage extension settings" text links in addonPrivateBrowsing.learnMore.label and private-browsing-learn-more could be considered to take along (see bug 1527127 comment 24 and the other attachments).

That should have been a new bug, not a comment on a bug. It got missed.

Comment 11

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/364ed778d761

Comment 12

[CosminB]

Attachment: Bug1534131.png

This issue is verified as fixed on Firefox 67.0a1 (20190312095443) under Win 7 64-bit and Mac OS X 10.14.1.

Please see the attached screenshot.