Closed Bug 1527127 Opened 2 years ago Closed 2 years ago

set permission on initial upgrade to incognito feature

Categories

(WebExtensions :: General, defect, P1)

defect

Tracking

(firefox67 verified)

VERIFIED FIXED
mozilla67
Tracking Status
firefox67 --- verified

People

(Reporter: mixedpuppy, Assigned: mixedpuppy)

References

(Blocks 1 open bug)

Details

Attachments

(7 files, 1 obsolete file)

No description provided.

When a user first upgrades to a version where incognito is enabled,
add the permission to all enabled extensions. This preserves user workflow
and addresses other issues (e.g. proxy). This will only happen once.

Group: mozilla-employee-confidential
Group: mozilla-employee-confidential
Attached image about:addons banner

Text change on about:addons

Assignee: nobody → mixedpuppy
Attachment #9044034 - Flags: ui-review?(emanuela)
Attachment #9044035 - Flags: ui-review?(emanuela)
Priority: -- → P1
Attached image post install panel with permission (obsolete) —
Attachment #9044037 - Flags: ui-review?(emanuela)
Attachment #9044034 - Attachment filename: Screen-Shot-2019-02-14-at-5.19.41-PM.png → about:addons banner
Attachment #9044034 - Attachment description: Screen Shot 2019-02-14 at 5.19.41 PM.png → about:addons banner
Comment on attachment 9044037 [details]
post install panel with permission

"Learn More" does not work as a button, unfortunately. It isn't clear what the user will learn more about since it is so far from the "Allow this extension to run in Private Windows" string. We need to be able to incorporate the link/string into the main message. Linking via button won't work.
Attachment #9044037 - Flags: ui-review?(emanuela) → ui-review+
Comment on attachment 9044034 [details]
about:addons banner

Looks good!
Attachment #9044034 - Flags: ui-review?(emanuela) → ui-review+

(In reply to Shane Caraveo (:mixedpuppy) from comment #4)

Created attachment 9044035 [details]
private window first runhttps://bugzilla.mozilla.org/enter_bug.cgi

Looks good!

Comment on attachment 9044034 [details]
about:addons banner

Looks good.

Question: why the message bar is sticky?
Can we unstick it? It's pretty long, and I'm afraid it will annoying to the end users who already act on it. If it's something complicated, I'm ok to track this in a separate bug.

Flags: needinfo?(mixedpuppy)
Attachment #9044035 - Flags: ui-review?(emanuela) → ui-review+
Comment on attachment 9044037 [details]
post install panel with permission

It looks good. 

If possible, I'll add to the checkbox ~8/16px of margin-top. It needs a bit more air on top.

(In reply to emanuela [ux] from comment #10)

Question: why the message bar is sticky?
Can we unstick it? It's pretty long, and I'm afraid it will annoying to the end users who already act on it. If it's something complicated, I'm ok to track this in a separate bug.

I'm not clear what this is about. What message bar?

Flags: needinfo?(mixedpuppy) → needinfo?(emanuela)
Attached video messagebar.mov

The message bar it's the banner in about:addons.

I attached a video that shows what I described in the other comment.

Flags: needinfo?(emanuela)

(In reply to emanuela [ux] from comment #13)

Created attachment 9044199 [details]
messagebar.mov

The message bar it's the banner in about:addons.

I attached a video that shows what I described in the other comment.

That is the way that block works. It could change in a followup, it will affect all usage of that block.

Flags: needinfo?(emanuela)

(In reply to Shane Caraveo (:mixedpuppy) from comment #14)

(In reply to emanuela [ux] from comment #13)

Created attachment 9044199 [details]
messagebar.mov

The message bar it's the banner in about:addons.

I attached a video that shows what I described in the other comment.

That is the way that block works. It could change in a followup, it will affect all usage of that block.

I think I never noticed cos the block was never so tall. I'll create a followup bug. This small issue is not a blocker.

Flags: needinfo?(emanuela)

more padding on top of checkbox (using margin: 8px 4px 2px;)

Attachment #9044037 - Attachment is obsolete: true
Attachment #9045294 - Flags: ui-review?(emanuela)
Comment on attachment 9045294 [details]
post install panel with permission.png

Good for me! Thank you, Shane
Attachment #9045294 - Flags: ui-review?(emanuela) → ui-review+
Duplicate of this bug: 1529099

How does this work with bug 1513344? Do we send privateBrowsingAllowed "on" as soon as the doorhanger value is set (or not set)?

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(lgreco)

(In reply to David Durst [:ddurst] from comment #19)

How does this work with bug 1513344? Do we send privateBrowsingAllowed "on" as soon as the doorhanger value is set (or not set)?

Bug 1513344 doesn't yet cover this, we filed bug 1529347 as the follow up in which we will record an additional telemetry event when a user is enabling an extension on PB windows from the install doorhanger.

Flags: needinfo?(mixedpuppy)
Flags: needinfo?(lgreco)
Pushed by scaraveo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3063f37eb7b2
set permission for enabled extensions on initial upgrade r=aswan
https://hg.mozilla.org/integration/autoland/rev/30aad4a580eb
update addon panel text for private windows r=flod,Gijs,mstriemer,rpl
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67

(In reply to Cosmin Sabou [:CosminS] from comment #23)

https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb

+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">

I’m afraid this is an option, and hence should not end with a trailing period. The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).

Also see https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Menu_and_control_labels.

(In reply to Ton [:Tonnes] from comment #24)

(In reply to Cosmin Sabou [:CosminS] from comment #23)

https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb

+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">

I’m afraid this is an option, and hence should not end with a trailing period. The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).

Also see https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Menu_and_control_labels.

That document shouldn't be used as point of reference for en-US copy. If such a reference can be created, it should live here and be done by the team in charge of copy
https://design.firefox.com/photon/copy/punctuation.html

(In reply to Ton [:Tonnes] from comment #24)

(In reply to Cosmin Sabou [:CosminS] from comment #23)

https://hg.mozilla.org/mozilla-central/rev/30aad4a580eb

+<!ENTITY addonPostInstall.incognito.label "Allow this extension to run in Private Windows.">

I’m afraid this is an option

For clarity, it's a checkbox (and yes, normally they don't have a closing period).

Attached file Bug1527127.zip

This issue is verified as fixed on Firefox 67.0a1 (20190304215035) under Win 7 64-bit and Mac OS X 10.14.1.

After updating Nightly from an older version to the latest one, with some installed extensions, the enabled extensions are automatically granted in PB.

The post install panel is displayed, like in the Comment 17.

Please see the attached video and screenshot.

The banner from about:addons is permanently displayed while scrolling, this issue will be tracked in a separate bug.

Status: RESOLVED → VERIFIED
Depends on: 1534131

(In reply to Ton [:Tonnes] from comment #24)

The same may apply to addonPrivateBrowsing.learnMore.label and private-browsing-learn-more (see legacy-learn-more).

Given it's a complete sentence, not on an option, I think the period is appropriate. I'll let Flod & Meridel decide.

See attachment 9044034 [details] and attachment 9044035 [details].

Flags: needinfo?(mwalkington)
Flags: needinfo?(francesco.lodolo)

(That's a copy question, not l10n)

Flags: needinfo?(francesco.lodolo)

No period at the end of the link. Following patterns established in other parts of the product, including new Private Windows new tab.

Flags: needinfo?(mwalkington)
Depends on: 1534686
See Also: → 1544975
You need to log in before you can comment on or make changes to this bug.