1534499 - [remote-dbg-next] Wait for hiding both shortName and name when remove USB runtime in tests

Status: RESOLVED FIXED

(DevTools :: about:debugging, enhancement, P1)

Description

[Daisuke Akatsuka (:daisuke)]

Similar to bug 1534304.
Currently, we update text of sidebar item of USB by shortName from ADB and name from appinfo when connects/disconnects. Thus, we might need to wait for hiding both shortName and name when remove USB runtime in other tests as well.

Comment 1

[Mellina Y.]

Hi Daisuke,

Can I try to solve this bug or is it taken already?

Thanks!

Comment 2

[Daisuke Akatsuka (:daisuke)]

Hi Mellina, thank you for having interest this!
Yeah, please fix this one!
If you have any questions, please feel free to let me know :)

Thanks again.

Comment 3

[Mellina Y.]

Hi Daisuke,

Sure, I'll have a look at it today and will let you know if I have questions!

Thanks!

Comment 4

[Mellina Y.]

Attachment: Bug 1534499 - Wait for hiding both shortName and name when remove USB runtime in tests r?daisuke

Comment 5

[Mellina Y.]

Hi Daisuke,

Sorry for the delay.

I'm not sure if this patch is right. I have inserted that piece of code on the removeRuntime() occurances and ran a mach mochitest <file path> for each of the files.

I didn't insert into the devtools/client/aboutdebugging-new/test/browser/helper-mocks.js because I didn't figure out what to do.

Please let me know if it's correct or a total miss!

Thanks!

Comment 6

[Daisuke Akatsuka (:daisuke)]

Thank you so much, Mellina!
I will replay in Phabricator.

Comment 7

[Mellina Y.]

Checkin needed to land. Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/db33a524a097
Wait for hiding both shortName and name when remove USB runtime in tests r=daisuke

Comment 9

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/db33a524a097