Closed Bug 1534499 Opened 9 months ago Closed 9 months ago

[remote-dbg-next] Wait for hiding both shortName and name when remove USB runtime in tests

Categories

(DevTools :: about:debugging, enhancement, P1)

enhancement

Tracking

(firefox68 fixed)

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: daisuke, Assigned: pong7219)

References

(Blocks 1 open bug)

Details

(Whiteboard: [remote-debugging-reserve])

Attachments

(1 file)

Similar to bug 1534304.
Currently, we update text of sidebar item of USB by shortName from ADB and name from appinfo when connects/disconnects. Thus, we might need to wait for hiding both shortName and name when remove USB runtime in other tests as well.

Hi Daisuke,

Can I try to solve this bug or is it taken already?

Thanks!

Hi Mellina, thank you for having interest this!
Yeah, please fix this one!
If you have any questions, please feel free to let me know :)

Thanks again.

Flags: needinfo?(pong7219)

Hi Daisuke,

Sure, I'll have a look at it today and will let you know if I have questions!

Thanks!

Flags: needinfo?(pong7219)

Hi Daisuke,

Sorry for the delay.

I'm not sure if this patch is right. I have inserted that piece of code on the removeRuntime() occurances and ran a mach mochitest <file path> for each of the files.

I didn't insert into the devtools/client/aboutdebugging-new/test/browser/helper-mocks.js because I didn't figure out what to do.

Please let me know if it's correct or a total miss!

Thanks!

Flags: needinfo?(dakatsuka)

Thank you so much, Mellina!
I will replay in Phabricator.

Flags: needinfo?(dakatsuka)
Assignee: nobody → pong7219
Status: NEW → ASSIGNED
Priority: -- → P1
Whiteboard: [remote-debugging-reserve]
Attachment #9051451 - Attachment description: Bug 1534499 - [remote-dbg-next] Wait for hiding both shortName and name when remove USB runtime in tests r?daisuke → Bug 1534499 - Wait for hiding both shortName and name when remove USB runtime in tests r?daisuke

Checkin needed to land. Thanks!

Keywords: checkin-needed

Pushed by ccoroiu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/db33a524a097
Wait for hiding both shortName and name when remove USB runtime in tests r=daisuke

Keywords: checkin-needed
Status: ASSIGNED → RESOLVED
Closed: 9 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.