1534508 - Startup should handle being launched without calling ProcessUpdates

Status: RESOLVED FIXED

(Toolkit :: Startup and Profile System, defect)

Description

[Robert Strong (they/them - no direct email)]

Not sure when startup changed but it is calling ProcessUpdates when being launched with an existing instance instead of handing off to the existing instance before ProcessUpdates.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance.

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 9050347 [details]
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance.

Haven't had chance to test this yet but I'd expect this to return us to the previous state where we check for existing instances and remote to them before calling ProcessUpdates.

But that leads me to a question, wasn't this always an issue for cases where users were running with -no-remote where we wouldn't check for an existing instance?

Comment 4

[Robert Strong (they/them - no direct email)]

I haven't seen bugs on issues when using -no-remote. It is possible it was an issue and I'll check on Windows if there was previously.

Comment 5

[Robert Strong (they/them - no direct email)]

It looks like -no-remote also has had this issue since day one of app update though the lack of bug reports make me think it didn't cause crashes such as in bug 1534485

Comment 6

[Robert Strong (they/them - no direct email)]

Comment on attachment 9050347 [details]
Bug 1534508: Move ProcessUpdates to after we have attempted to remote arguments to an existing instance.

I'm fine with giving this feedback+ but with all of the recent changes to startup it is impossible for me to say whether there will be other unintended side affects in startup.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/35a77a480420
Move ProcessUpdates to after we have attempted to remote arguments to an existing instance. r=rstrong

Comment 8

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/35a77a480420