1534552 - Properly document selection resetting in UrlbarInput::_loadURL

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Dão Gottwald [:dao]]

In bug 1533691, mak said that this code would be "necessary for spoof protection, so that the domain stays visible." The code comment however says: "Ensure the start of the URL is visible for usability reasons."
This is vague enough to be useless if not actively misleading.

Comment 1

[Marco Bonardo [:mak]]

Yeah, it's actually both usability and spoof prevention, the host is an important information that should stay visible as far as possible.

Comment 2

[Dão Gottwald [:dao]]

Gonna up the priority because P5 is almost wontfix and the current documentation is just not good. Also marking Task. (By definition tasks have low user impact, and making all tasks P5s seems a bit silly.)

Comment 3

[Omkar Konaraddi]

Attachment: Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/611f5c630114
Properly document selection resetting in UrlbarInput::_loadURL r=adw

Comment 5

[Dão Gottwald [:dao]]

Comment on attachment 9069791 [details]
Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw!

Beta/Release Uplift Approval Request

• User impact if declined: No user impact, could potentially avoid conflicts with future quantumbar uplifts
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: No
• If yes, steps to reproduce:
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): Only fixing up a comment
• String changes made/needed:

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/611f5c630114

Comment 7

[Julien Cristau [:jcristau]]

Comment on attachment 9069791 [details]
Bug 1534552 - Properly document selection resetting in UrlbarInput::_loadURL r=adw!

updating a comment, effectively a no-op, approved for 68.0b8

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/releases/mozilla-beta/rev/fc39189ea163