Closed Bug 1534631 Opened 6 years ago Closed 6 years ago

Crash in [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal]

Categories

(Core :: Storage: localStorage & sessionStorage, defect, P2)

Product:
Core
Component:
Storage: localStorage & sessionStorage
Platform:
Unspecified
Linux
Type:
defect

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox-esr60 --- unaffected
firefox66 --- unaffected
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: janv, Assigned: janv)

References

(Blocks 1 open bug)

Details

(Keywords: crash)

Crash Data

This bug is for crash report bp-172fde29-05a4-4641-8532-687be0190312.

Top 10 frames of crashing thread:

0 libxul.so <name omitted> xpcom/base/nsCOMPtr.h:367
1 libxul.so mozilla::dom:: xpcom/base/nsCOMPtr.h:672
2 libxul.so mozilla::dom:: dom/localstorage/ActorsParent.cpp:5885
3 libxul.so mozilla::dom:: dom/localstorage/ActorsParent.cpp:6491
4 libxul.so mozilla::dom:: dom/localstorage/ActorsParent.cpp:5684
5 libxul.so nsThread::ProcessNextEvent xpcom/threads/nsThread.cpp:1179
6 libxul.so NS_ProcessNextEvent xpcom/threads/nsThreadUtils.cpp:482
7 libxul.so mozilla::ipc::MessagePumpForNonMainThreads::Run ipc/glue/MessagePump.cpp:303
8 libxul.so nsThread::ThreadFunc ipc/chromium/src/base/message_loop.cc:315
9 libnspr4.so _pt_root nsprpub/pr/src/pthreads/ptthread.c:201
Blocks: 1517090
Priority: -- → P2

This also looks like bug 1533789.

I mean we get a dangling pointer from the hash table and then we try to addref it.

Crash Signature: [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] → [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [nsCOMPtr_base::assign_with_AddRef | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal]
Crash Signature: [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [nsCOMPtr_base::assign_with_AddRef | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] → [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [@ nsCOMPtr_base::assign_with_AddRef | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal]
Crash Signature: [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [@ nsCOMPtr_base::assign_with_AddRef | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] → [@ <name omitted> | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [@ nsCOMPtr_base::assign_with_AddRef | mozilla::dom::(anonymous namespace)::PrepareDatastoreOp::CheckClosingDatastoreInternal] [@ nsCOMPtr_base::…
No longer blocks: 1517090
Blocks: 1540402

Jan thinks this might have been fixed by his work in bug 1533789. Let's watch for any new crash reports here.

Yes, 99% sure this was fixed in bug 1533789.

Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Assignee: nobody → jvarga
You need to log in before you can comment on or make changes to this bug.