Closed Bug 1534830 Opened 2 years ago Closed 2 years ago

Ci.nsIFaviconService.FAVICON_DEFAULT_URL is undefined

Categories

(Firefox :: Address Bar, defect, P2)

defect

Tracking

()

RESOLVED FIXED
Firefox 67
Tracking Status
firefox67 --- fixed

People

(Reporter: standard8, Assigned: dao)

References

(Blocks 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

UrlbarUtils references Ci.nsIFaviconService.FAVICON_DEFAULT_URL but this is undefined.

The only reference to FAVICON_DEFAULT_URL in nsIFaviconService.idl is a c++ #define.

I added this in bug 1524536 at Marco's request, but didn't actually check it is valid.

Blocks: 1479513

uooops, you are right, we should use PlacesUtils.favicons.defaultFavicon

Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b06a29334b8
Fix UrlbarUtils.ICON.DEFAULT. r=mak
Flags: needinfo?(dao+bmo)
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17c3b29f3b07
Fix UrlbarUtils.ICON.DEFAULT. r=mak
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.