Ci.nsIFaviconService.FAVICON_DEFAULT_URL is undefined
Categories
(Firefox :: Address Bar, defect, P2)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox67 | --- | fixed |
People
(Reporter: standard8, Assigned: dao)
References
Details
(Whiteboard: [fxsearch])
Attachments
(1 file)
UrlbarUtils references Ci.nsIFaviconService.FAVICON_DEFAULT_URL but this is undefined.
The only reference to FAVICON_DEFAULT_URL in nsIFaviconService.idl is a c++ #define.
I added this in bug 1524536 at Marco's request, but didn't actually check it is valid.
|
||
Comment 1•5 years ago
|
||
uooops, you are right, we should use PlacesUtils.favicons.defaultFavicon
|
Assignee | |
Updated•5 years ago
|
|
|
Assignee | |
Comment 2•5 years ago
|
||
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5b06a29334b8 Fix UrlbarUtils.ICON.DEFAULT. r=mak
|
||
Comment 4•5 years ago
|
||
Backed out changeset 5b06a29334b8 (Bug 1534830) for bc failures at browser_startup.js.
Backout: https://hg.mozilla.org/integration/autoland/rev/916f90879f389f7b64b460506acce8f2f1f981bf
Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=5b06a29334b8f96ab458bea01dcf70645936a9c5&selectedJob=233602754
Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233602754&repo=autoland&lineNumber=2627
|
|
Assignee | |
Updated•5 years ago
|
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/17c3b29f3b07 Fix UrlbarUtils.ICON.DEFAULT. r=mak
|
||
Comment 6•5 years ago
|
||
| bugherder | ||
Description
•