Ci.nsIFaviconService.FAVICON_DEFAULT_URL is undefined

RESOLVED FIXED in Firefox 67

Status

()

defect
P2
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: standard8, Assigned: dao)

Tracking

(Blocks 3 bugs)

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch])

Attachments

(1 attachment)

UrlbarUtils references Ci.nsIFaviconService.FAVICON_DEFAULT_URL but this is undefined.

The only reference to FAVICON_DEFAULT_URL in nsIFaviconService.idl is a c++ #define.

I added this in bug 1524536 at Marco's request, but didn't actually check it is valid.

uooops, you are right, we should use PlacesUtils.favicons.defaultFavicon

Assignee

Updated

2 months ago
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED

Comment 3

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5b06a29334b8
Fix UrlbarUtils.ICON.DEFAULT. r=mak
Assignee

Updated

2 months ago
Flags: needinfo?(dao+bmo)

Comment 5

2 months ago
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/17c3b29f3b07
Fix UrlbarUtils.ICON.DEFAULT. r=mak

Comment 6

2 months ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
You need to log in before you can comment on or make changes to this bug.