1534830 - Ci.nsIFaviconService.FAVICON_DEFAULT_URL is undefined

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P2)

Description

[Mark Banner (:standard8)]

UrlbarUtils references Ci.nsIFaviconService.FAVICON_DEFAULT_URL but this is undefined.

The only reference to FAVICON_DEFAULT_URL in nsIFaviconService.idl is a c++ #define.

I added this in bug 1524536 at Marco's request, but didn't actually check it is valid.

Comment 1

[Marco Bonardo [:mak]]

uooops, you are right, we should use PlacesUtils.favicons.defaultFavicon

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1534830 - Fix UrlbarUtils.ICON.DEFAULT. r=Standard8,mak

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5b06a29334b8
Fix UrlbarUtils.ICON.DEFAULT. r=mak

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 5b06a29334b8 (Bug 1534830) for bc failures at browser_startup.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/916f90879f389f7b64b460506acce8f2f1f981bf

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=5b06a29334b8f96ab458bea01dcf70645936a9c5&selectedJob=233602754

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233602754&repo=autoland&lineNumber=2627

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/17c3b29f3b07
Fix UrlbarUtils.ICON.DEFAULT. r=mak

Comment 6

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/17c3b29f3b07