Closed Bug 1534858 Opened 6 years ago Closed 6 years ago

windows/aarch64 - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin

Categories

(Firefox Build System :: General, defect, P5)

Product:
Firefox Build System
Component:
General
Type:
defect

Tracking

(firefox68 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla68
Tracking Flags:
Tracking Status
firefox68 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: gbrown)

References

Details

Attachments

(1 file)

Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester
47 bytes, text/x-phabricator-request
Details | Review

#[markdown(off)]
Filed by: egao [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=233501438&repo=try

https://queue.taskcluster.net/v1/task/Doc7bcI5R-aAxFZp245xzw/runs/0/artifacts/public/logs/live_backing.log

Test: bc7

Platform: windows10-aarch64

Context:

When environment is being set up:
23:19:32 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozcrash
23:19:32 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozdebug
23:19:33 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozdevice
23:19:34 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozfile
23:19:34 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozhttpd
23:19:35 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozinfo
23:19:36 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozinstall
23:19:37 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozleak
23:19:37 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozlog
23:19:38 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\moznetwork
23:19:39 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozprocess
23:19:39 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozprofile
23:19:40 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozproxy
23:19:41 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozrunner
23:19:42 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozscreenshot
23:19:42 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\moztest
23:19:43 INFO - Processing c:\tasks\task_1552432518\build\tests\mozbase\mozversion
23:19:44 INFO - Installing collected packages: mozterm, manifestparser, mozcrash, mozdebug, mozdevice, mozfile, mozhttpd, mozinfo, mozInstall, mozleak, mozlog, moznetwork, mozprocess, mozprofile, mozproxy, mozrunner, mozscreenshot, moztest, mozversion
23:19:44 INFO - Running setup.py install for mozterm: started
23:19:44 INFO - Running setup.py install for mozterm: finished with status 'done'
23:19:44 INFO - Running setup.py install for manifestparser: started
23:19:45 INFO - Running setup.py install for manifestparser: finished with status 'done'
23:19:45 INFO - Running setup.py install for mozcrash: started
23:19:46 INFO - Running setup.py install for mozcrash: finished with status 'done'
23:19:46 INFO - Running setup.py install for mozdebug: started
23:19:47 INFO - Running setup.py install for mozdebug: finished with status 'done'
23:19:47 INFO - Running setup.py install for mozdevice: started
23:19:48 INFO - Running setup.py install for mozdevice: finished with status 'done'
23:19:48 INFO - Running setup.py install for mozfile: started
23:19:49 INFO - Running setup.py install for mozfile: finished with status 'done'
23:19:49 INFO - Running setup.py install for mozhttpd: started
23:19:50 INFO - Running setup.py install for mozhttpd: finished with status 'done'
23:19:50 INFO - Running setup.py install for mozinfo: started
23:19:51 INFO - Running setup.py install for mozinfo: finished with status 'done'
23:19:51 INFO - Running setup.py install for mozInstall: started
23:19:51 INFO - Running setup.py install for mozInstall: finished with status 'done'
23:19:51 INFO - Running setup.py install for mozleak: started
23:19:52 INFO - Running setup.py install for mozleak: finished with status 'done'
23:19:52 INFO - Running setup.py install for mozlog: started
23:19:53 INFO - Running setup.py install for mozlog: finished with status 'done'
23:19:54 INFO - Running setup.py install for moznetwork: started
23:19:54 INFO - Running setup.py install for moznetwork: finished with status 'done'
23:19:54 INFO - Running setup.py install for mozprocess: started
23:19:55 INFO - Running setup.py install for mozprocess: finished with status 'done'
23:19:55 INFO - Running setup.py install for mozprofile: started
23:19:56 INFO - Running setup.py install for mozprofile: finished with status 'done'
23:19:56 INFO - Running setup.py install for mozproxy: started
23:19:57 INFO - Running setup.py install for mozproxy: finished with status 'done'
23:19:57 INFO - Running setup.py install for mozrunner: started
23:19:58 INFO - Running setup.py install for mozrunner: finished with status 'done'
23:19:58 INFO - Running setup.py install for mozscreenshot: started
23:19:59 INFO - Running setup.py install for mozscreenshot: finished with status 'done'
23:19:59 INFO - Running setup.py install for moztest: started
23:20:00 INFO - Running setup.py install for moztest: finished with status 'done'
23:20:00 INFO - Running setup.py install for mozversion: started
23:20:01 INFO - Running setup.py install for mozversion: finished with status 'done'
23:20:03 INFO - Successfully installed manifestparser-1.2 mozInstall-2.0.0 mozcrash-1.1.0 mozdebug-0.1.1 mozdevice-3.0.0 mozfile-2.0.0 mozhttpd-0.7 mozinfo-1.0.0 mozleak-0.2 mozlog-4.0 moznetwork-0.27 mozprocess-1.0.0 mozprofile-2.2.0 mozproxy-1.0 mozrunner-7.4.0 mozscreenshot-0.1 mozterm-1.0.0 moztest-0.8 mozversion-2.1.0
23:20:03 INFO - Return code: 0

When environment is being checked:
23:22:05 INFO - Current package versions:
23:22:05 INFO - Twisted == 10.2.0
...
23:22:05 INFO - mozcrash == 1.1.0

When mozcrash is being called:
23:37:41 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\63163965-3871-44a5-8e02-31aed50563e0.dmp for [8432]
23:37:41 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 5820
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\372f6074-384e-4c98-b2fe-f8d808701750.dmp for [5820]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 6876
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\5fd2686a-77a5-4b34-a0d9-aa3721fbe7f7.dmp for [6876]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 8136
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\25d03e8d-893a-4650-b0f7-b3862dde1478.dmp for [8136]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 2524
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\a70336b3-e633-4899-a4da-52a96b44712a.dmp for [2524]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 7848
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\a9b4bada-9628-47a0-beba-92436fe477ce.dmp for [7848]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 10448
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\7c53a39c-40dd-46f1-ba1e-3ef65683e499.dmp for [10448]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to terminate pid 10448: 5
23:37:42 INFO - Killing process: 7992
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\ea52c551-e7e4-40fc-ab0c-d44f5d13c665.dmp for [7992]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to terminate pid 7992: 5
23:37:42 INFO - Killing process: 10640
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\e260604e-f3cf-4cce-82c0-d1ac4d8854bb.dmp for [10640]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 10104
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\408ad358-5dd7-4af0-ae55-0c16cbf69440.dmp for [10104]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to terminate pid 10104: 5
23:37:42 INFO - Killing process: 7060
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\1e1f34fe-e297-40a4-8b46-1b331d46c2c1.dmp for [7060]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 8344
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\fbd35559-d357-48e1-ba75-9d9eaf14e390.dmp for [8344]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 INFO - Killing process: 10740
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\289466cf-b565-497b-95d5-65e38a89e90c.dmp for [10740]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to get handle for pid 10740: 87
23:37:42 INFO - Killing process: 9812
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\cfc7a893-867a-4d2e-a391-7a19220a1e90.dmp for [9812]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to get handle for pid 9812: 87
23:37:42 INFO - Killing process: 10876
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\238364a2-8241-4408-ad8f-790388149cc6.dmp for [10876]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to get handle for pid 10876: 87
23:37:42 INFO - Killing process: 9968
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\e6a950fd-fee0-434e-8da2-6bf1f24984df.dmp for [9968]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to get handle for pid 9968: 87
23:37:42 INFO - Killing process: 1808
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\5a21dce7-bc8b-4f84-a3fc-0ac1378025f9.dmp for [1808]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to get handle for pid 1808: 87
23:37:42 INFO - Killing process: 10844
23:37:42 INFO - Not taking screenshot here: see the one that was previously logged
23:37:42 INFO - mozcrash Using C:\tasks\task_1552432518\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmp3ehjvg.mozrunner\minidumps\7b1a23f4-e534-40db-a099-ceda0c3fe8e2.dmp for [10844]
23:37:42 ERROR - mozcrash minidumpwriter not found in C:\tasks\task_1552432518\build\tests\bin
23:37:42 WARNING - mozcrash kill_pid(): unable to terminate pid 10844: 5
23:37:42 INFO - psutil found pid 10844 dead
23:37:42 INFO - TEST-INFO | Main app process: exit 1
23:37:42 INFO - Buffered messages finished

Bug 1526276 enabled crash reporter for windows10-aarch64 builds, and it was tested by QA and uplifted to beta. Something is happening for mocrash in mochitest-browser-chrome chunk 7 though, as the system appears to be unable to find mozcrash at the specified path.

It looks like this is complaining because minidumpwriter.exe is not found.

If you examine the target.common.tests.tar.gz for an x86_64 windows build, there is a bin/minidumpwriter.exe included; that - and other executables - are missing from target.common.tests.tar.gz for an aarch64 build. Maybe https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/testing/tools/minidumpwriter/moz.build#7 needs to change?

(In reply to Geoff Brown [:gbrown] from comment #2)

It looks like this is complaining because minidumpwriter.exe is not found.

If you examine the target.common.tests.tar.gz for an x86_64 windows build, there is a bin/minidumpwriter.exe included; that - and other executables - are missing from target.common.tests.tar.gz for an aarch64 build. Maybe https://searchfox.org/mozilla-central/rev/89414a1df52d06cfc35529afb9a5a8542a6e4270/testing/tools/minidumpwriter/moz.build#7 needs to change?

I did some digging after checking the line of code you referenced, and compared builds from mozilla-central for winows7/opt, as well as my own builds on try. I found that if an artifact build is selected (which I use almost exclusively) a minidumpwriter.exe is not generated regardless of the processor architecture.

I will try running these browser-chrome tests with a non-artifact build which will generate the minidumpwriter.exe that it is looking for and see if the outcomes change.

For artifact builds, I think we need something like

https://hg.mozilla.org/try/rev/de3361d9ca84d1299a89f2915b9b8fd9a4e411f0#l2.16

but I haven't confirmed that...waiting on some try builds to see if I can learn more.

minidumpwriter.exe included in target.common.tests.tar.gz for all windows artifact builds

https://treeherder.mozilla.org/#/jobs?repo=try&tier=1%2C2%2C3&revision=f8970cc8f00f8735268fe22b87f28987203c620a

With the aarch64 crash reproduced:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=233697273&repo=try&lineNumber=1687

20:28:05 INFO - mozcrash Using C:\tasks\task_1552446311\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmpgqzwwi.mozrunner\minidumps\dd2466da-bb43-4c75-aa7e-40043df61786.dmp for [9056]
20:28:05 INFO - Error 0x8007012B in MiniDumpWriteDump
20:28:05 ERROR - mozcrash minidumpwriter exited with status: 1

Dump files are produced, but they are invalid, at just 64 bytes.

I have done what I set out to do -- include minidumpwriter.exe in test environments -- only to find that it doesn't seem to work on aarch64!

(In reply to Geoff Brown [:gbrown] from comment #6)

20:28:05 INFO - mozcrash Using C:\tasks\task_1552446311\build\tests\bin\minidumpwriter.exe to write a dump to c:\users\testdr~1\appdata\local\temp\tmpgqzwwi.mozrunner\minidumps\dd2466da-bb43-4c75-aa7e-40043df61786.dmp for [9056]
20:28:05 INFO - Error 0x8007012B in MiniDumpWriteDump
20:28:05 ERROR - mozcrash minidumpwriter exited with status: 1

:chmanchester -- We are trying to use minidumpwriter.exe on Windows/aarch64. Do you have an idea of what might be going wrong here?

Flags: needinfo?(cmanchester)

I'm sorry, I don't have a specific suggestion here. From a little searching it doesn't look like the minidumpwriter code is doing anything obviously wrong or architecture specific. We may need someone with more aarch64 expertise and hardware to debug with to take a look.

One longshot but quick thing to try would be to see if our Python process is able to write a minidump in this case by disabling this check: https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/testing/mozbase/mozcrash/mozcrash/mozcrash.py#420

Flags: needinfo?(cmanchester)

(In reply to Chris Manchester (:chmanchester) from comment #9)

One longshot but quick thing to try would be to see if our Python process is able to write a minidump in this case by disabling this check: https://searchfox.org/mozilla-central/rev/aae527894a97ee3bbe0c2cfce9c67c59e8b8fcb9/testing/mozbase/mozcrash/mozcrash/mozcrash.py#420

Thanks Chris. I tried that, but that also generates empty minidumps:

https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=234254650&repo=try&lineNumber=1597

I think I'll proceed with my patch to make minidumpwriter.exe and crashinject.exe available to windows tests, then open a new bug to make them work on aarch64.

Test automation code assumes crashinject.exe is available on Win32:
https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/build/automation.py.in#356
and minidumpwriter.exe on Windows when there is a 32/64 bit mismatch between python and the application build:
https://searchfox.org/mozilla-central/rev/7abb9117c8500ed20833746c9f8e800fce3a4688/testing/mozbase/mozcrash/mozcrash/mozcrash.py#428
so I think these should be available for Windows tests, and I suspect they have only been left out accidentally.

I will file a new bug to get minidumpwriter working on aarch64.

See Also: → 1536221
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d12b8cd1cee8 Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester

It's worth noting those failures didn't show up on landing of this bug because those tasks weren't running because the EME build (Be) task it depended on was failing for other reasons.

I see that crashinjectdll.dll was unexpectedly added to target.zip for the Be (build-win64-aarch64-eme/opt) job.

https://taskcluster-artifacts.net/PUfOPwWjQ8aOxORU3ZKmag/0/public/logs/live_backing.log

15:12:34 INFO - package> mozmake.EXE[5]: Entering directory 'z:/task_1553263163/build/src/obj-firefox/browser/installer'
15:12:34 INFO - package> Compressing...
15:12:34 INFO - package> cd ../../dist && z:/task_1553263163/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.make_zip 'firefox' 'target.zip'
...
15:12:34 INFO - package> adding: firefox/chrome.manifest (208 bytes security) (stored 0%)
15:12:34 INFO - package> adding: firefox/crashinjectdll.dll (208 bytes security) (deflated 56%)
15:12:34 INFO - package> adding: firefox/crashreporter.exe (208 bytes security) (deflated 54%)

That did not happen for any of the other Windows builds.

https://taskcluster-artifacts.net/Jbs2naF_TAieLVwHSUMPBQ/0/public/logs/live_backing.log

14:47:48 INFO - package> z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.zip -C ../../dist/bin --strip z:/build/build/src/obj-firefox/dist/target.jsshell.zip js.exe mozglue.dll nss3.dll vcruntime140.dll msvcp140.dll
14:47:48 INFO - package> mozmake.EXE[5]: Leaving directory 'z:/build/build/src/obj-firefox/browser/installer'
14:48:05 INFO - package> mozmake.EXE[5]: Entering directory 'z:/build/build/src/obj-firefox/browser/installer'
14:48:05 INFO - package> Compressing...
14:48:05 INFO - package> cd ../../dist && z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe -m mozbuild.action.make_zip 'firefox' 'target.zip'
...
14:48:05 INFO - package> adding: firefox/chrome.manifest (208 bytes security) (stored 0%)
14:48:05 INFO - package> adding: firefox/crashreporter.exe (208 bytes security) (deflated 54%)

Flags: needinfo?(gbrown)

In the normal, non-eme case, crashinjectdll.dll is built in <topobjdir>/build/win32/crashinjectdll and installed to <topobjdir>/dist/bin.

13:49:07     INFO -  mozmake.EXE[4]: Entering directory 'z:/build/build/src/obj-firefox/build/win32/crashinjectdll'
13:49:07     INFO -  z:/build/build/src/obj-firefox/_virtualenvs/init/Scripts/python.exe z:/build/build/src/config/nsinstall.py -R -m 644 'crashinjectdll.dll' '../../../dist/bin'

and then target.zip is built from <topobjdir>/dist/firefox -- so it makes sense that crashinjectdll.dll is not added to target.zip.

In the eme case, I do not see any sign of crashinjectdll.dll being built. Has it been obtained from the common.tests archive? (Then why wasn't crashinject.exe also added to the Be target.zip?) I wonder what Be is doing...

Be is a an artifact builds, and artifact builds install *.dll :( (see package-manifest.in)
Part of the problem is that dist/bin is kind of polluted with non-Firefox things. Part of the problem is that wildcard for artifact builds.

Attachment #9051762 - Attachment description: Bug 1534858 - Include crashinject.exe and minidumpwriter.exe in windows artifacts; r=chmanchester → Bug 1534858 - Include minidumpwriter.exe in windows artifacts; r=chmanchester
Component: Mozbase → General
Product: Testing → Firefox Build System
Version: Version 3 → unspecified
See Also: → 1539283
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6ee134f8c056 Include minidumpwriter.exe in windows artifacts; r=chmanchester

https://hg.mozilla.org/mozilla-central/rev/6ee134f8c056

Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox68: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: