Toast notifications do not work with `alerts.useSystemBackend=false`

VERIFIED FIXED in Firefox 66

Status

()

defect
--
major
VERIFIED FIXED
a month ago
8 days ago

People

(Reporter: nayinain, Assigned: agashlin)

Tracking

({regression})

67 Branch
mozilla67
Desktop
Windows 10
Points:
---

Firefox Tracking Flags

(firefox-esr60 unaffected, firefox65 unaffected, firefox66blocking verified, firefox67+ verified)

Details

Attachments

(1 attachment)

(Reporter)

Description

a month ago

Steps to reproduce:

  1. set alerts.useSystemBackend to false in about:config.
  2. open https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API
  3. click the Notify me! button on the page.

Actual results:
nothing happened.

Expected result:
notifications is shown.

regression range:

2019-03-13T17:15:35: INFO : Narrowed inbound regression window from [65a4518c, 067c3628] (3 builds) to [6927cfe9, 067c3628] (2 builds) (~1 steps left)
2019-03-13T17:15:35: DEBUG : Starting merge handling...
2019-03-13T17:15:35: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=067c36284e776e3e03d33d3ad99d110be04230af&full=1
2019-03-13T17:15:37: DEBUG : Found commit message:
Bug 1498973: Don't show a popup that should be hidden. r=jmathies

Differential Revision: https://phabricator.services.mozilla.com/D21801

Sorry for my bad English.

(Reporter)

Updated

a month ago
Blocks: 1498973
Keywords: regression
Component: Notifications and Alerts → Widget: Win32
Product: Toolkit → Core
(Assignee)

Comment 1

a month ago

[Tracking Requested - why for this release]: Bug 1498973 was uplifted to release, and Windows release has alerts.useSystemBackend turned off, so this will break notifications universally if we release it this way. I've verified that this bug is present in a fresh install of https://archive.mozilla.org/pub/firefox/candidates/66.0-candidates/build2/

Assignee: nobody → agashlin
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(lhenry)
Flags: needinfo?(lhenry)
(Assignee)

Comment 2

a month ago

The comment was correct, the base impl should always return false as we don't have an opinion about visibility.

Comment 4

a month ago
Pushed by agashlin@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8db388171af6
Fix non-nsView ShouldNotBeVisible(). r=jmathies
(Assignee)

Comment 5

a month ago

Thanks very much for spotting this before it hit release nayinain!

Comment 6

a month ago
bugherder
Status: ASSIGNED → RESOLVED
Last Resolved: a month ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla67
Severity: normal → major
Flags: qe-verify+

Can confirm the issue as described using 66.0- build 2 on Win10(ver.1903).
Fix verified with 66.0.3, 67.0b9.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.