1534935 - Toast notifications do not work with `alerts.useSystemBackend=false`

Status: VERIFIED FIXED

(Core :: Widget: Win32, defect)

Description

[nayinain]

Steps to reproduce:

1. set alerts.useSystemBackend to false in about:config.
2. open https://developer.mozilla.org/en-US/docs/Web/API/Notifications_API/Using_the_Notifications_API
3. click the Notify me! button on the page.

Actual results:
nothing happened.

Expected result:
notifications is shown.

regression range:

2019-03-13T17:15:35: INFO : Narrowed inbound regression window from [65a4518c, 067c3628] (3 builds) to [6927cfe9, 067c3628] (2 builds) (~1 steps left)
2019-03-13T17:15:35: DEBUG : Starting merge handling...
2019-03-13T17:15:35: DEBUG : Using url: https://hg.mozilla.org/integration/autoland/json-pushes?changeset=067c36284e776e3e03d33d3ad99d110be04230af&full=1
2019-03-13T17:15:37: DEBUG : Found commit message:
Bug 1498973: Don't show a popup that should be hidden. r=jmathies

Differential Revision: https://phabricator.services.mozilla.com/D21801

Sorry for my bad English.

Comment 1

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

[Tracking Requested - why for this release]: Bug 1498973 was uplifted to release, and Windows release has alerts.useSystemBackend turned off, so this will break notifications universally if we release it this way. I've verified that this bug is present in a fresh install of https://archive.mozilla.org/pub/firefox/candidates/66.0-candidates/build2/

Comment 2

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Attachment: Bug 1534935: Fix non-nsView ShouldNotBeVisible(). r?jmathies

The comment was correct, the base impl should always return false as we don't have an opinion about visibility.

Comment 3

[Julien Cristau [:jcristau]]

Fixed by backout in 66.0 build3.

https://hg.mozilla.org/releases/mozilla-release/rev/164a57c0cdf0

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8db388171af6
Fix non-nsView ShouldNotBeVisible(). r=jmathies

Comment 5

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

Thanks very much for spotting this before it hit release nayinain!

Comment 6

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/8db388171af6

Comment 7

[Cristian Fogel [:cfogel]]

Can confirm the issue as described using 66.0- build 2 on Win10(ver.1903).
Fix verified with 66.0.3, 67.0b9.

Comment 8

[Jim]

Is this functioning in 73.0.1 (64-bit) on Windows10 because I do not see any of the notifications showing up in the Windows10 Action Center. I do see the popups but the notifications are not automatically pushed into Action Center. I have toggled alerts.useSystemBackend to True with no difference. If I happen to see a popup notification and click on the arrow --> in the upper right corner of the notification to move it to Action Center the notification simply disappears.

Comment 9

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

(In reply to Jim from comment #8)

Is this functioning in 73.0.1 (64-bit) on Windows10 because I do not see any of the notifications showing up in the Windows10 Action Center. I do see the popups but the notifications are not automatically pushed into Action Center. I have toggled alerts.useSystemBackend to True with no difference. If I happen to see a popup notification and click on the arrow --> in the upper right corner of the notification to move it to Action Center the notification simply disappears.

Hi Jim, that doesn't sound like this issue, please file a new bug or feature request (or is this the same issue you mention in bug 1545326?)

Comment 10

[Jim]

Adam yes it is the same is in 1545326 sorry about that. I updated that bug with confirmation that notifications from YouTube are primarily broken at least from my point of view.

Comment 11

[Firefox Bug Husbandry Bot]

Please specify a root cause for this bug. See :tmaity for more information.

Comment 12

[Adam Gashlin (he/him) [:agashlin] (ex-moco)]

This was likely a typo or copy-paste error that slipped through because it was easy to read the reasoning of the comment and miss that the code was simply doing the opposite.