Closed Bug 1535096 Opened 3 years ago Closed 3 years ago

Port bug 1532514: add sinon-7.2.7.js to pref security.uris_using_eval_with_system_principal

Categories

(Thunderbird :: General, task)

task
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 67.0

People

(Reporter: jorgk-bmo, Assigned: jorgk-bmo)

Details

(Whiteboard: [Thunderbird-testfailure: X debug all])

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1522608 +++

It's back :-(

TEST-UNEXPECTED-FAIL | services/common/tests/unit/test_async_iterator.js | xpcshell return code: 1
PID 1864 | Assertion failure: false (do not use eval with system privileges), at /builds/worker/workspace/build/src/caps/nsScriptSecurityManager.cpp:475
PROCESS-CRASH | services/common/tests/unit/test_async_iterator.js | application crashed [@ nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction(JSContext*, JS::Handle<JS::Value>)]

TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGate.js | xpcshell return code: 1
PID 2939 | Assertion failure: false (do not use eval with system privileges), at /builds/worker/workspace/build/src/caps/nsScriptSecurityManager.cpp:475
PROCESS-CRASH | toolkit/components/featuregates/test/unit/test_FeatureGate.js | application crashed [@ nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction(JSContext*, JS::Handle<JS::Value>)]
TEST-UNEXPECTED-FAIL | toolkit/components/featuregates/test/unit/test_FeatureGateImplementation.js | xpcshell return code: 1
PID 2944 | Assertion failure: false (do not use eval with system privileges), at /builds/worker/workspace/build/src/caps/nsScriptSecurityManager.cpp:475
PROCESS-CRASH | toolkit/components/featuregates/test/unit/test_FeatureGateImplementation.js | application crashed [@ nsScriptSecurityManager::ContentSecurityPolicyPermitsJSAction(JSContext*, JS::Handle<JS::Value>)]

Flags: needinfo?(geoff)
Flags: needinfo?(acelists)
Flags: needinfo?(acelists)

Adding sinon-7.2.7.js?

Yes, that's my guess.

Comment on attachment 9050760 [details] [diff] [review]
1535096-uris_using_eval_with_system_principal.patch

It's actually my patch and your r+, but whatever :)
Attachment #9050760 - Flags: review?(acelists) → review+

I'll swap it around, although I worked out the details myself, but whatever :-)

Flags: needinfo?(geoff)

Pushed by mozilla@jorgk.com:
https://hg.mozilla.org/comm-central/rev/399d50b7a204
Port bug 1532514: add sinon-7.2.7.js to pref security.uris_using_eval_with_system_principal. r=jorgk

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Summary: replace use of eval - take 2 → Port bug 1532514: add sinon-7.2.7.js to pref security.uris_using_eval_with_system_principal
Target Milestone: --- → Thunderbird 67.0
Type: enhancement → task
You need to log in before you can comment on or make changes to this bug.