1535484 - Use mozlog for node debugger linting test

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Bug 1496341 added the node(debugger) job which lints devtools/client/debugger/new/

https://searchfox.org/mozilla-central/source/taskcluster/ci/source-test/node.yml

The linting failures of that job are not properly formatted with the mozlog format (no TEST-UNEXPECTED-FAIL or TEST-UNEXPECTED-ERROR) and thus Treeherder and its log viewer don't show a summary what is wrong with the job.

Example: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=233996724&revision=ee3da141383532c5f82be55ea74fc5e0b4622ec8

https://firefox-source-docs.mozilla.org/mozbase/mozlog.html

See mach's treeherder parameter usage for the ESlint job:
https://searchfox.org/mozilla-central/rev/f1c7ba91fad60bfea184006f3728dd6ac48c8e56/taskcluster/ci/source-test/mozlint.yml#63-68

Comment 1

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b274cabedb6
Switch node devtools and debugger tasks to tier 3 until they provide structured failure output. a=tasks-without-failure-summary DONTBUILD

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

The node(debugger) and node(devtools) task have been switched to Tier 3 because they don't provide failures in a format which gets picked up by the failure summary generation and one has to always look into the raw log what went wrong. Until this is fixed, the jobs will not be sheriffed.

Comment 3

[Jason Laster [:jlast]]

Attachment: Bug 1535484 - Use mozlog for node debugger linting test. r=jdescottes

Comment 5

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/3b274cabedb6

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f8f02e7922a5
Use mozlog for node debugger linting test. r=jdescottes

Comment 7

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/f8f02e7922a5

Comment 8

[Julian Descottes [:jdescottes]]

I will add a patch to fix this for the devtools suite as well now.

Comment 9

[Julian Descottes [:jdescottes]]

Attachment: Bug 1535484 - Add proper logs for node-devtools test suite

Comment 10

[Julian Descottes [:jdescottes]]

Successful try example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=762b58fc7c7985c800634c18bd663e42807a637e
Error try example: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6c92b4535a1c52f4170e9a763b9ea8d3c0f6416e&selectedJob=245747219

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f005c5114e06
Add proper logs for node-devtools test suite r=jlast

Comment 12

[Natalia Csoregi [:nataliaCs]]

Backed out for node devtools failures.

backout: https://hg.mozilla.org/integration/autoland/rev/5003c4244ea22c6a1337b3716bc641cb17891638

push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=f005c5114e062c9ad0a5552784a97b56488f81a4&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-devtools-tests%2Cnode%28devtools%29

failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245756720&repo=autoland&lineNumber=346

[task 2019-05-10T14:40:54.804Z] TEST START | mocha | webconsole
[task 2019-05-10T14:40:54.804Z] [devtools-node-test-runner] Run yarn test in test folder
[task 2019-05-10T14:40:58.659Z] warning package.json: No license field
[task 2019-05-10T14:40:58.659Z] Warning: Each child in an array or iterator should have a unique "key" prop.
[task 2019-05-10T14:40:58.659Z]
[task 2019-05-10T14:40:58.659Z] Check the top-level render call using <span>. See https://fb.me/react-warning-keys for more information.
[task 2019-05-10T14:40:58.659Z] in Unknown
[task 2019-05-10T14:40:58.659Z] Warning: Failed prop type: MessageIcon: prop type onRewindClick is invalid; it must be a function, usually from the prop-types package, but received undefined.
[task 2019-05-10T14:40:58.659Z] in MessageIcon
[task 2019-05-10T14:40:58.659Z] error Command failed with exit code 1.
[task 2019-05-10T14:40:58.659Z] [devtools-node-test-runner] Error log
[task 2019-05-10T14:40:58.660Z] warning package.json: No license field
[task 2019-05-10T14:40:58.660Z] Warning: Each child in an array or iterator should have a unique "key" prop.
[task 2019-05-10T14:40:58.660Z]
[task 2019-05-10T14:40:58.660Z] Check the top-level render call using <span>. See https://fb.me/react-warning-keys for more information.
[task 2019-05-10T14:40:58.661Z] in Unknown
[task 2019-05-10T14:40:58.661Z] Warning: Failed prop type: MessageIcon: prop type onRewindClick is invalid; it must be a function, usually from the prop-types package, but received undefined.
[task 2019-05-10T14:40:58.661Z] in MessageIcon
[task 2019-05-10T14:40:58.661Z] error Command failed with exit code 1.
[task 2019-05-10T14:40:58.661Z]
[task 2019-05-10T14:40:58.662Z] [devtools-node-test-runner] Parse errors from the test logs
[task 2019-05-10T14:40:58.662Z] TEST-UNEXPECTED-FAIL | mocha | webconsole | TypeError: dispatch is not a function
[taskcluster 2019-05-10 14:40:59.323Z] === Task Finished ===
[taskcluster 2019-05-10 14:40:59.324Z] Unsuccessful task run with exit code: 1 completed in 335.109 seconds

Comment 13

[Julian Descottes [:jdescottes]]

Looks like a recent changeset broke the webconsole test (still failing after the backout, but the suite is no longer tier 1). My revision was based on 65a693623, so something that landed after that. Will bisect.

Comment 14

[David Walsh :davidwalsh]

This was likely my work, though jest was passing for me locally before I merged:

https://phabricator.services.mozilla.com/rMCU804d239e671bc7572641c0c864fa7a147c338b3e

I'm checking it out quickly now.

Comment 15

[Julian Descottes [:jdescottes]]

This was regressed by Bug 1230194. I will skip the failing console mocha test here in order to land.

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/865ec5a708ba
Add proper logs for node-devtools test suite r=jlast

Comment 17

[Dorel Luca [:dluca]]

Backed out changeset 865ec5a708ba (bug 1535484) for ESlint failure. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=245780461&repo=autoland&lineNumber=289

Push with failures:
https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=865ec5a708ba94d700672df65d5ab5ea81c01898

Backout:
https://hg.mozilla.org/integration/autoland/rev/cacd53838ee6aa12cf3ef1f974704e51a2782150

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/15d5a90bad2d
Add proper logs for node-devtools test suite r=jlast

Comment 19

[Razvan Maries]

https://hg.mozilla.org/mozilla-central/rev/15d5a90bad2d