1535517 - Assertion failure: !nsSVGUtils::OuterSVGIsCallingReflowSVG(this) (do not call ScheduleReflowSVGNonDisplayText when the outer SVG frame is under ReflowSVG)

Status: RESOLVED FIXED

(Core :: SVG, defect, P3)

Description

[violet.bugreport]

Attachment: testcase.html

Bug 897887 has a regression somewhere. It was supposed to have been fixed 6 years ago, but now the testcase in that bug still triggers the same assertion failure on the trunk.

Comment 1

[Cameron McCormack (:heycam)]

My fault for not adding the test case when landing bug 897887.

Comment 2

[Cameron McCormack (:heycam)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=9e7056d82a590631c0aba1f0cb4b564d1e8198dd

Comment 3

[Cameron McCormack (:heycam)]

Attachment: Bug 1535517 - Don't schedule SVG text reflow in response to bidi resolution.

Comment 4

[violet.bugreport]

Thanks for fixing this bug. Could you also review my patch to bug 1072758? I actually discovered this regression when working on bug 1072758. I want to be confirmed there is no caveat in my patch.

Comment 5

[Cameron McCormack (:heycam)]

Sure, I will comment over on that review. Thanks for picking up that assertion fix!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7517b9beb5e6
Don't schedule SVG text reflow in response to bidi resolution. r=jwatt

Comment 7

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/7517b9beb5e6