1535584 - Intermittent video glitches on AppRTC calls

Status: VERIFIED FIXED

(Core :: WebRTC: Audio/Video, defect, P2)

Description

[Dan Minor [:dminor]]

+++ This bug was initially created as a clone of Bug #1315283 +++

[Steps to reproduce]:

1. Launch Firefox on 2 separate stations
2. Go to https://apprtc.appspot.com/ on both stations and initiate a call (enter a room)
3. Wait a few minutes and pay attention to the video playback

[Expected result]:

• The call is properly taking place, no video or audio issues are encountered

[Actual result]:

• Video glitches occur at the bottom of the window mainly at the beginning of the call and sometimes they keep emerge until the end of the call (see the attached screenshot https://goo.gl/VE9DHi)

Comment 1

[Dan Minor [:dminor]]

Looks like the fix from Bug 1315283 was accidentally dropped as part of the branch 64 update in Bug 1376873.

Comment 2

[Dan Minor [:dminor]]

Attachment: Bug 1535584 - Restore UpdateCodecFrameSize to vp9_impl.cc; r=ng!

Comment 3

[Neha Kochar [:neha]]

[Tracking Requested - why for this release]:

Dan, once landed in nightly, is the patch safe for uplift to 67 beta?

Comment 4

[Dan Minor [:dminor]]

(In reply to Neha Kochar [:neha] from comment #3)

[Tracking Requested - why for this release]:

Dan, once landed in nightly, is the patch safe for uplift to 67 beta?

Yes, this should be very safe, it is just restoring code that was accidentally removed.

Comment 5

[Pascal Chevrel:pascalc (PTO until April 26)]

Tracking for 67 as we will take an uplift, thanks!

Comment 6

[Dan Minor [:dminor]]

Marking leave-open until the fix is upstreamed.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0898f9cfe092
Restore UpdateCodecFrameSize to vp9_impl.cc; r=bwc

Comment 8

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/0898f9cfe092

Comment 9

[Dan Minor [:dminor]]

Comment on attachment 9051357 [details]
Bug 1535584 - Restore UpdateCodecFrameSize to vp9_impl.cc; r=ng!

Beta/Release Uplift Approval Request

• Feature/Bug causing the regression: Bug 1376873
• User impact if declined: Rendering glitches when the resolution changes while using vp9 codec.
• Is this code covered by automated tests?: No
• Has the fix been verified in Nightly?: No
• Needs manual test from QE?: Yes
• If yes, steps to reproduce: See Comment 1.
• List of other uplifts needed: None
• Risk to taking this patch: Low
• Why is the change risky/not risky? (and alternatives if risky): This is low risk as it is just restoring code that was accidentally removed during the webrtc.org branch 64 update.
• String changes made/needed: None

Comment 10

[Pascal Chevrel:pascalc (PTO until April 26)]

FYI, since we have STR, I would like the fix to be verified on Nightly before approving the uplift to Beta.

Comment 11

[Daniel Bodea [:danibodea]]

This issue could not be reproduced anymore on Nightly v68.0a1 wit the patch from comment 8. I will mark firefox68 as Verified. Leaving the qa-verify+ flag for latter uplift verification. Thank you!

Comment 12

[Pascal Chevrel:pascalc (PTO until April 26)]

Comment on attachment 9051357 [details]
Bug 1535584 - Restore UpdateCodecFrameSize to vp9_impl.cc; r=ng!

Fix for a P2 WebRTC visual regression since 64, verified on Nightly, uplift approved for 67 Beta 5, thanks!

Comment 13

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/851a8b384476

Comment 15

[Dan Minor [:dminor]]

Filed upstream issue here: https://bugs.chromium.org/p/webrtc/issues/detail?id=10476. Marking as fixed as we can track upstreaming this through that issue.

Comment 16

[Kanchan Kumari QA]

I verified this bug fix on the latest nightly (Build ID 20190325095153), Fx beta 67.0b5 (Build ID 20190325115716)by making a video call between MacOS, Linux and Windows 10 for around 10 minutes. I didn't observe any video glitches during this call.

Comment 17

[Dan Minor [:dminor]]

Upstream code review: https://webrtc-review.googlesource.com/c/src/+/129781