1535659 - Revisit the "combobox" accessibility roles on QuantumBar after bug 1513337

Status: RESOLVED FIXED

(Firefox :: Address Bar, task, P3)

Description

[Mark Banner (:standard8)]

In bug 1534661 we're implementing a solution that allows the results view to be listed as a "combobox" in accessibility terms.

At the moment we have the urlbar with role="combobox", and the urlbarResults-view with role="listbox". The urlbar one is in a xml binding, and the urlbarResults-view is not. This breaks the encapsulation enforced via accessibility.

When bug 1534661 lands, the parent div to urlbarResults-view will also have role="combobox" which is enough to make this work well enough for now.

Once we fix bug 1513337, we'll no longer have the xml binding, and as a result, we should re-evaluate whether or not we still need the fix from bug 1534661.

Comment 1

[Dão Gottwald [:dao]]

Attachment: Bug 1535659 - Remove bogus role="combobox" from urlbar results body now that the input isn't anonymous anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3f0bdecf3d0b
Remove bogus role="combobox" from urlbar results body now that the input isn't anonymous anymore. r=Standard8

Comment 3

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/3f0bdecf3d0b