Closed Bug 1535659 Opened 5 years ago Closed 5 years ago

Revisit the "combobox" accessibility roles on QuantumBar after bug 1513337

Categories

(Firefox :: Address Bar, task, P3)

task
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 70
Iteration:
70.1 - Jul 8 - 21
Tracking Status
firefox70 --- fixed

People

(Reporter: standard8, Assigned: dao)

References

(Depends on 1 open bug)

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

In bug 1534661 we're implementing a solution that allows the results view to be listed as a "combobox" in accessibility terms.

At the moment we have the urlbar with role="combobox", and the urlbarResults-view with role="listbox". The urlbar one is in a xml binding, and the urlbarResults-view is not. This breaks the encapsulation enforced via accessibility.

When bug 1534661 lands, the parent div to urlbarResults-view will also have role="combobox" which is enough to make this work well enough for now.

Once we fix bug 1513337, we'll no longer have the xml binding, and as a result, we should re-evaluate whether or not we still need the fix from bug 1534661.

Type: enhancement → task
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Iteration: --- → 70.1 - Jul 8 - 21
Points: --- → 1
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3f0bdecf3d0b
Remove bogus role="combobox" from urlbar results body now that the input isn't anonymous anymore. r=Standard8
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 70
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: