1535665 - Remove support for older unix systems - that clearly aren't used anymore

Status: RESOLVED FIXED

(NSPR :: NSPR, enhancement)

Description

[Ludovic Hirlimann [:Usul]]

I'd like to clean up nspr from unnecessary ifdef.

List of OS I think should go away

• True64 (DGUX, OSF1)
• IRIX
• SYMBIAN

All have had their latest release more than 5 years ago.

Comment 1

[Ludovic Hirlimann [:Usul]]

Attachment: removing OLD unsupported unix Systems part 1 OSF1/Tru64 bug 1535665

Remove OSF1/Tru64 from nspr. Last release of Tru64 was 8 years ago according to https://en.wikipedia.org/wiki/Tru64_UNIX. Before the patch, nspr could compile on Tru64, after it wont.

Comment 2

[Ludovic Hirlimann [:Usul]]

Plan is to move on with other one once this one is review accepted ...

Comment 3

[Ludovic Hirlimann [:Usul]]

Attachment: Bug 1535665 part 2 remove DGUX - it's either the old name of Tru64 or https://en.wikipedia.org/wiki/DG/UX , both are dead r=glandium!

Comment 4

[Ludovic Hirlimann [:Usul]]

Attachment: Bug 1535665 remove support for IRIX from NSPR - latest release from 2006 per https://en.wikipedia.org/wiki/IRIX r=glandium?

Comment 5

[Ludovic Hirlimann [:Usul]]

Attachment: Bug 1535665 remove dead OS from nspr - symbian https://en.wikipedia.org/wiki/Symbian r=glandium?

Comment 6

[Ludovic Hirlimann [:Usul]]

Attachment: Remove older/no more supported OS from NSPR - beos died with Be Inc in 2001 , the successor haikuos uses it s own defines as per https://github.com/haikuports/haikuports/blob/master/dev-libs/nspr/patches/nspr-4.19.patchset Bug 1535665 r=kaie?

Comment 7

[Kai Engert [:KaiE:]]

Removal is probably fine, but it would be nice to ask on https://lists.mozilla.org/listinfo/dev-tech-nspr if anyone is still depending on these platforms to work with latest NSPR/NSS.

Did you verify using a try build that Firefox still builds after removing all of these?

A full removal of these platforms should probably remove all related build rules from NSS and Firefox, too.

Comment 8

[Ludovic Hirlimann [:Usul]]

(In reply to Kai Engert (:kaie:) from comment #7)

Removal is probably fine, but it would be nice to ask on https://lists.mozilla.org/listinfo/dev-tech-nspr if anyone is still depending on these platforms to work with latest NSPR/NSS.

I did on mozilla.dev.tech.nspr - message Subject "Cleaning up old platform code" posted on 14/3/2019

Did you verify using a try build that Firefox still builds after removing all of these?

Nope I haven't will work on that (I don't think I have level1 these days enabled anywhere - will sort that out and come back here once I have launched said builds).

A full removal of these platforms should probably remove all related build rules from NSS and Firefox, too.

I don't mind following up with cleanups in NSS/firefox. My plan was -> cleanup NSPR once done cleanup NSS and then cleanup FF/TB.

Comment 9

[Ludovic Hirlimann [:Usul]]

Attachment: Removal of Irix support take II. latest release from 2006 per https://en.wikipedia.org/wiki/IRIX , Bug 1535665 r=kaie?

Comment 10

[Ludovic Hirlimann [:Usul]]

(In reply to Ludovic Hirlimann [:Usul] from comment #9)

Created attachment 9053125 [details]
Removal of Irix support take II. latest release from 2006 per https://en.wikipedia.org/wiki/IRIX , Bug 1535665 r=kaie?

Try build of FF https://treeherder.mozilla.org/#/jobs?repo=try&revision=ba4ee6af2f125685d4c00279bed77525157ccc2c

Comment 11

[Ludovic Hirlimann [:Usul]]

Attachment: Remove symbian support from NSPR / Bug 1535665 r=kaie?

Comment 12

[Ludovic Hirlimann [:Usul]]

(In reply to Ludovic Hirlimann [:Usul] from comment #11)

Created attachment 9053144 [details]
Remove symbian support from NSPR / Bug 1535665 r=kaie?

FF try build https://treeherder.mozilla.org/#/jobs?repo=try&revision=82e889e3a01f1308eb4fa66e546ee0f8450302dc

Comment 13

[Ludovic Hirlimann [:Usul]]

Attachment: Bug 1535665 , remove older non supported OS - beos r=kaie?

Comment 14

[Ludovic Hirlimann [:Usul]]

(In reply to Ludovic Hirlimann [:Usul] from comment #13)

Created attachment 9053261 [details]
Bug 1535665 , remove older non supported OS - beos r=kaie?

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5a6173d4b973f4eebc4cf4b21e2ae1274b2a964e

Here you go Firefox compiles with the 4 patches attached. Id like these to get reviewed and landed before I continue on other arch (older versions of AIX, Neutino QNX , QNX , OS/2 , also I'll need to see if these still have a need for nspr NSS).

Comment 15

[Ludovic Hirlimann [:Usul]]

Ok looks like both QNX and neutrino are still used. I won't touch these.

Comment 16

[Kai Engert [:KaiE:]]

r=kaie on all patches. I'll land them.

Comment 17

[Kai Engert [:KaiE:]]

https://hg.mozilla.org/projects/nspr/rev/4c5bf3d7f1a86940a5643f3bf84d9f51ce642acc
https://hg.mozilla.org/projects/nspr/rev/8f9ad2721df04f6802e75432ead11baae8912762
https://hg.mozilla.org/projects/nspr/rev/181a43f0b5135978a6d7ae48daf66635cb6b09a5
https://hg.mozilla.org/projects/nspr/rev/d2e28a2f7c2a066793593f30bca024d409cadf0e
https://hg.mozilla.org/projects/nspr/rev/505dc2877e6fe5e23a3bb3e392ecef18538ee04c
https://hg.mozilla.org/projects/nspr/rev/fa340cd5573e3aaf7e8487ea92326d4d293bd8b6