Closed Bug 1535994 Opened 6 years ago Closed 6 years ago

Add struct for bytecode and directly associated data, and indirectly associated "per script" data

Tracking

()

Status:

RESOLVED FIXED

Milestone:

mozilla68

Tracking Flags:

Tracking

Status

firefox68

---

fixed

People

(Reporter: arai, Assigned: arai)

References

(Blocks 1 open bug)

Details

Attachments

(11 files)

Bug 1535994 - Part 1: Add BytecodeSection class with BytecodeVector. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 2: Move source notes to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 3: Move lastTarget to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 4: Move stackDepth to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 5: Move tryNodeList to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 6: Move scope to BytecodeSection class and PerScriptData class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 7: Move object and number to PerScriptData class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 8: Move resume/yield info to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 9: Move atomIndices to PerScriptData class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 10: Move JIT information to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review
Bug 1535994 - Part 11: Move line/colum information to BytecodeSection class. r?jorendorff 6 years ago Tooru Fujisawa [:arai] 47 bytes, text/x-phabricator-request		Details \| Review

Tooru Fujisawa [:arai]

Assignee

Description

•

6 years ago

to achieve bug 1464311 (bytecode-let composition), we need a structure that represents following:

bytecode itself, and all data directly associated with specific opcode/index inside the bytecode

this corresponds to each bytecode-let.
source notes/try notes etc are also in this struct, because it points specific opcode/index in the bytecode, and should be modified while composition.

all data associated with bytecode but not directly to specific opcode

Data that is shared across multiple bytecode-lets.
this includes AtomIndexMap, CGNumberList, CGObjectList, CGScopeList, etc,
that is referred from the bytecode, and added while emitting bytecode.

while EmitSection is removed in bug 1284719,
I'm about to add yet another similar structure, with above rule.

Tooru Fujisawa [:arai]

Assignee

Updated

•

6 years ago

Blocks: 1536037

Tooru Fujisawa [:arai]

Assignee

Comment 1

•

6 years ago

WIP patch:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=2591b05cb381f58c731b9a8a62cc5b891988cd93
https://hg.mozilla.org/try/pushloghtml?changeset=2591b05cb381

will post after testing patch for bug 1536037 and bug 1464311 based on them.

Tooru Fujisawa [:arai]

Assignee

Comment 2

•

6 years ago

Attached file Bug 1535994 - Part 1: Add BytecodeSection class with BytecodeVector. r?jorendorff — Details

Tooru Fujisawa [:arai]

Assignee

Comment 3

•

6 years ago

Attached file Bug 1535994 - Part 2: Move source notes to BytecodeSection class. r?jorendorff — Details

Depends on D25731

Tooru Fujisawa [:arai]

Assignee

Comment 4

•

6 years ago

Attached file Bug 1535994 - Part 3: Move lastTarget to BytecodeSection class. r?jorendorff — Details

Depends on D25732

Tooru Fujisawa [:arai]

Assignee

Comment 5

•

6 years ago

Attached file Bug 1535994 - Part 4: Move stackDepth to BytecodeSection class. r?jorendorff — Details

Depends on D25733

Tooru Fujisawa [:arai]

Assignee

Comment 6

•

6 years ago

Attached file Bug 1535994 - Part 5: Move tryNodeList to BytecodeSection class. r?jorendorff — Details

Depends on D25734

Tooru Fujisawa [:arai]

Assignee

Comment 7

•

6 years ago

Attached file Bug 1535994 - Part 6: Move scope to BytecodeSection class and PerScriptData class. r?jorendorff — Details

Depends on D25735

Tooru Fujisawa [:arai]

Assignee

Comment 8

•

6 years ago

Attached file Bug 1535994 - Part 7: Move object and number to PerScriptData class. r?jorendorff — Details

Depends on D25736

Tooru Fujisawa [:arai]

Assignee

Comment 9

•

6 years ago

Attached file Bug 1535994 - Part 8: Move resume/yield info to BytecodeSection class. r?jorendorff — Details

Depends on D25737

Tooru Fujisawa [:arai]

Assignee

Comment 10

•

6 years ago

Attached file Bug 1535994 - Part 9: Move atomIndices to PerScriptData class. r?jorendorff — Details

Depends on D25738

Tooru Fujisawa [:arai]

Assignee

Comment 11

•

6 years ago

Attached file Bug 1535994 - Part 10: Move JIT information to BytecodeSection class. r?jorendorff — Details

Depends on D25739

Tooru Fujisawa [:arai]

Assignee

Comment 12

•

6 years ago

Attached file Bug 1535994 - Part 11: Move line/colum information to BytecodeSection class. r?jorendorff — Details

Depends on D25740

Pulsebot

Comment 13

•

6 years ago

Pushed by arai_a@mac.com: https://hg.mozilla.org/integration/autoland/rev/384cdd1ee833 Part 1: Add BytecodeSection class with BytecodeVector. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/b77efa8567a2 Part 2: Move source notes to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/ee3359178d5f Part 3: Move lastTarget to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/4f5084424c22 Part 4: Move stackDepth to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/7c763b9a2118 Part 5: Move tryNodeList to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/8a480b0bbd05 Part 6: Move scope to BytecodeSection class and PerScriptData class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/096ab8585046 Part 7: Move object and number to PerScriptData class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/db520471b407 Part 8: Move resume/yield info to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/fdd1177e499a Part 9: Move atomIndices to PerScriptData class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/e56d1810fb40 Part 10: Move JIT information to BytecodeSection class. r=jorendorff https://hg.mozilla.org/integration/autoland/rev/d5975f907521 Part 11: Move line/colum information to BytecodeSection class. r=jorendorff

Bogdan Tara[:bogdan_tara | bogdant]

Comment 14

•

6 years ago

Backed out 11 changesets (Bug 1535994) for BytecodeEmitter.cpp related build bustages

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&revision=d5975f907521e4a5fe727cd52e3799b60b97beb7&selectedJob=239290488

Backout link: https://hg.mozilla.org/integration/autoland/rev/7fb3acf38591979f105306e0c8f3441e75c95bd5

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=239290488&repo=autoland&lineNumber=6788

[task 2019-04-10T09:14:41.965Z] 09:14:41 [task 2019-04-10T09:14:41.995Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.996Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:41.997Z] 09:14:41 [task 2019-04-10T09:14:42.039Z] 09:14:42 [task 2019-04-10T09:14:42.043Z] 09:14:42 [task 2019-04-10T09:14:42.045Z] 09:14:42 [task 2019-04-10T09:14:42.045Z] 09:14:42 [task 2019-04-10T09:14:42.046Z] 09:14:42 [task 2019-04-10T09:14:42.046Z] 09:14:42 INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/media/libaom'
INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/js/src/frontend'
INFO - /builds/worker/workspace/build/src/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-darwin11 -o Unified_cpp_js_src_frontend0.o -c -flto=thin -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DWASM_HUGE_MEMORY -DJS_CACHEIR_SPEW -DJS_STRUCTURED_SPEW -DJS_HAS_CTYPES -DFFI_BUILDING -DEXPORT_JS_API -DMOZ_HAS_MOZGLUE -I/builds/worker/workspace/build/src/js/src/frontend -I/builds/worker/workspace/build/src/obj-firefox/js/src/frontend -I/builds/worker/workspace/build/src/obj-firefox/js/src -I/builds/worker/workspace/build/src/js/src -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/js/src/js-confdefs.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-noexcept-type -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-common -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -Werror -fno-strict-aliasing -Werror=format -Wno-shadow -MD -MP -MF .deps/Unified_cpp_js_src_frontend0.o.pp /builds/worker/workspace/build/src/obj-firefox/js/src/frontend/Unified_cpp_js_src_frontend0.cpp
INFO - In file included from /builds/worker/workspace/build/src/obj-firefox/js/src/frontend/Unified_cpp_js_src_frontend0.cpp:20:
ERROR - /builds/worker/workspace/build/src/js/src/frontend/BytecodeEmitter.cpp:2024:28: error: no member named 'code' in 'js::frontend::BytecodeEmitter'
INFO - jsbytecode* code = this->code(offset);
INFO - ~~~~ ^
ERROR - /builds/worker/workspace/build/src/js/src/frontend/BytecodeEmitter.cpp:2027:3: error: use of undeclared identifier 'updateDepth'
INFO - updateDepth(offset);
INFO - ^
INFO - 2 errors generated.
INFO - /builds/worker/workspace/build/src/config/rules.mk:805: recipe for target 'Unified_cpp_js_src_frontend0.o' failed
ERROR - make[4]: *** [Unified_cpp_js_src_frontend0.o] Error 1
INFO - make[4]: Leaving directory '/builds/worker/workspace/build/src/obj-firefox/js/src/frontend'
INFO - make[4]: *** Waiting for unfinished jobs....
INFO - make[4]: Entering directory '/builds/worker/workspace/build/src/obj-firefox/config/external/icu/i18n'
INFO - /builds/worker/workspace/build/src/clang/bin/clang++ -isysroot /builds/worker/workspace/build/src/MacOSX10.11.sdk --target=x86_64-darwin11 -o numparse_compositions.o -c -flto=thin -fvisibility=hidden -fvisibility-inlines-hidden -DNDEBUG=1 -DTRIMMED=1 -DU_I18N_IMPLEMENTATION -DUCONFIG_NO_TRANSLITERATION -DUCONFIG_NO_REGULAR_EXPRESSIONS -DUCONFIG_NO_LEGACY_CONVERSION -DU_USING_ICU_NAMESPACE=0 -DU_NO_DEFAULT_INCLUDE_UTF_HEADERS=1 -DU_CHARSET_IS_UTF8 -DU_HAVE_NL_LANGINFO_CODESET=0 -I/builds/worker/workspace/build/src/config/external/icu/i18n -I/builds/worker/workspace/build/src/obj-firefox/config/external/icu/i18n -I/builds/worker/workspace/build/src/intl/icu/source/common -I/builds/worker/workspace/build/src/obj-firefox/dist/include -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nspr -I/builds/worker/workspace/build/src/obj-firefox/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /builds/worker/workspace/build/src/obj-firefox/mozilla-config.h -Qunused-arguments -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -Qunused-arguments -Wall -Wbitfield-enum-conversion -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wshadow-field-in-constructor-modified -Wsign-compare -Wtype-limits -Wunreachable-code -Wunreachable-code-return -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wfloat-overflow-conversion -Wfloat-zero-conversion -Wloop-analysis -Wc++1z-compat -Wc++2a-compat -Wcomma -Wimplicit-fallthrough -Werror=non-literal-null-conversion -Wstring-conversion -Wtautological-overlap-compare -Wtautological-unsigned-enum-zero-compare -Wtautological-unsigned-zero-compare -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-error=backend-plugin -Wno-error=return-std-move -Wno-error=atomic-alignment -Wformat -Wformat-security -Wno-gnu-zero-variadic-macro-arguments -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-sized-deallocation -fcrash-diagnostics-dir=/builds/worker/artifacts -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -fstack-protector-strong -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -Xclang -load -Xclang /builds/worker/workspace/build/src/obj-firefox/build/clang-plugin/libclang-plugin.so -Xclang -add-plugin -Xclang moz-check -O3 -fno-omit-frame-pointer -funwind-tables -frtti -MD -MP -MF .deps/numparse_compositions.o.pp /builds/worker/workspace/build/src/intl/icu/source/i18n/numparse_compositions.cpp
WARNING - /builds/worker/workspace/build/src/intl/icu/source/i18n/numparse_compositions.cpp:66:5: warning: loop will run at most once (loop increment never executed) [-Wunreachable-code-loop-increment]
INFO - for (auto& matcher : *this) {
INFO - ^~~
INFO - 1 warning generated.

Flags: needinfo?(arai.unmht)

Tooru Fujisawa [:arai]

Assignee

Comment 15

•

6 years ago

Tooru Fujisawa [:arai]

Assignee

Updated

•

6 years ago

Flags: needinfo?(arai.unmht)

Daniel Varga [:dvarga]

Comment 16

•

6 years ago

bugherder

Status: ASSIGNED → RESOLVED

Closed: 6 years ago

status-firefox68: --- → fixed

Resolution: --- → FIXED

Target Milestone: --- → mozilla68

You need to log in before you can comment on or make changes to this bug.