1536522 - Fennec x86-64 beta doesn't have the right package name

Status: VERIFIED FIXED

(Release Engineering :: General, defect, P1)

Description

[Mihai Tabara [:mtabara]⌚️GMT]

    package_names_check.validate(apks_metadata_per_paths)
  File "/builds/scriptworker/lib/python3.6/site-packages/mozapkpublisher/common/apk/checker.py", line 26, in validate
    raise BadSetOfApks('Expected product types {}, found {}'.format(self.expected_product_types, types))
mozapkpublisher.common.exceptions.BadSetOfApks: Expected product types ['org.mozilla.firefox_beta'], found {'org.mozilla.firefox_beta', 'org.mozilla.fennec_aurora'}
exit code: 1

From here via this task

Comment 1

[Mihai Tabara [:mtabara]⌚️GMT]

Last Fennec beta we shipped was 66.0b13 with this pushapk task

At first glance, sounds like we have an additional dependency "build-signing-android-x86_64-nightly/opt" which we didn't have before.

Comment 2

[Mihai Tabara [:mtabara]⌚️GMT]

After more consideration, turns out that x86-64 thing is expected after all because of bug 1505538.
Most likely there's some inner build in-config that we may have forgotten to switch for beta x86-64. So far it rode the nigtly train successfully but when it merged to beta, it still defaulted to:

attribute: package='b'org.mozilla.fennec_aurora'' for /builds/scriptworker/work/cot/LZB2QnESRNCGOImU3cHLWw/public/build/target.apk"

Comment 3

[Johan Lorenzo [:jlorenzo]]

The error reported by PushApk is a valid one. The x86-64 APK is busted[1]. Its package name is org.mozilla.fennec_aurora instead of org.mozilla.firefox_beta.

I manually pushed the sane APKs to Google Play. However, we will hit that problem again, next week. We need to fix the package name. Moving the bug to Build System because the root cause comes from the build task.

[1] https://queue.taskcluster.net/v1/task/LZB2QnESRNCGOImU3cHLWw/runs/0/artifacts/public/build/target.apk

Comment 4

[Nick Alexander :nalexander [he/him]]

(In reply to Johan Lorenzo [:jlorenzo] from comment #3)

The error reported by PushApk is a valid one. The x86-64 APK is busted[1]. Its package name is org.mozilla.fennec_aurora instead of org.mozilla.firefox_beta.

How is this happening? Trunk/Nightly is producing org.mozilla.fennec_aurora just fine: aapt dump badging on https://queue.taskcluster.net/v1/task/dUUD4muTS1Cwu9YVpEhqNQ/runs/0/artifacts/public/build/target.apk yields

package: name='org.mozilla.fennec_aurora' versionCode='2015617951' versionName='68.0a1'

That suggests that one of the uplift/branch rewriting scripts isn't handling x86_64 -- but I can't figure out which one. All the other configure.sh is ABI-agnostic to the best of my knowledge.

Comment 5

[Johan Lorenzo [:jlorenzo]]

Good thinking! You're right, the mozconfig haven't been rewritten[1] on mergeday[2]. I can manually fix this and update the scripts. Moving bug out of the build system.

[1] https://searchfox.org/mozilla-beta/rev/f7b8b76f5953a7acd3c423fa1f2cf45ef13fa9f0/mobile/android/config/mozconfigs/android-x86_64/nightly#7 https://searchfox.org/mozilla-beta/rev/f7b8b76f5953a7acd3c423fa1f2cf45ef13fa9f0/mobile/android/config/mozconfigs/android-x86_64/debug#14
[2] https://hg.mozilla.org/releases/mozilla-beta/rev/a2e7f5c935da

Comment 6

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1536522 - Make Android mozconfig use the beta branding r=nalexander

Make Android mozconfig use the beta branding

Comment 7

[Johan Lorenzo [:jlorenzo]]

Attachment: Bug 1536522 - Let mergeday scripts handle missing Android mozconfigs

Let mergeday scripts handle missing Android mozconfigs

Depends on D24340

Comment 8

[Johan Lorenzo [:jlorenzo]]

Comment on attachment 9052537 [details]
Bug 1536522 - Make Android mozconfig use the beta branding r=nalexander

r+'d by nalexander on Phabricator.
Landed on beta at https://hg.mozilla.org/releases/mozilla-beta/rev/d199f4768de56941b633c1bdce7cba703b02274d. We don't want this patch on any other branch

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a19986b12bd6
Let mergeday scripts handle missing Android mozconfigs r=aki,nalexander

Comment 10

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/a19986b12bd6

Comment 11

[Chris Peterson [:cpeterson]]

I've confirmed that Fennec x86_64 is live in Fennec 68 Nightly and 67 Beta on the Google Play Store. And we're receiving some x86_64 crash reports from Fennec 67 Beta users.