1536672 - Implement webgl2 draft ext OVR_multiview2

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P2)

Comment 1

[Kelsey Gilbert [:jgilbert]]

Attachment: Bug 1536672 - Implement WebGL OVR_multiview2 behind draft flag.

Comment 2

[Kelsey Gilbert [:jgilbert]]

This bug tracks detecting and enabling OVR_multiview2 support when directly supported by drivers. (Windows+ANGLE, Android)

For desktop GL (Windows+GL, Mac, Linux), we'll need to emulate support for this.

Comment 3

[Kelsey Gilbert [:jgilbert]]

Following bug 1546558, I rebased this cset on it, but ran into mismatches where ANGLE's GLES driver thought a program had no multiview use, but our shader validation thought it had num_views:4. It turns out ANGLE's translater doesn't yet output OVR_multiview2 use into ESSL shaders, so we'll need to get that first.

Comment 4

[Imanol Fernandez]

FWIW I had to do these changes on Angle for the Servo Multiview implementation: https://github.com/google/angle/pull/10

Comment 5

[Kelsey Gilbert [:jgilbert]]

Great, thanks! I'm upstreaming fixes here:
https://chromium-review.googlesource.com/c/angle/angle/+/1585452

It seems to be working locally!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a649f69f29df
Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot

Comment 7

[Alexandru Michis [:malexandru]]

Backed out changeset a649f69f29df for failing crashtest at WebGLContextValidate.cpp

Backout link: https://hg.mozilla.org/integration/autoland/rev/a75ad7be71ba5ad28c3eb07ca7649b086480862d

Push with failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&revision=a649f69f29df63d2d188a7d2e04ac1322b8853c0&selectedJob=247914977

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=247914977&repo=autoland&lineNumber=1460

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a9e860d35d5b
Implement WebGL OVR_multiview2 behind draft flag. r=lsalzman,qdot

Comment 9

[Andrei Ciure[:aciure]]

https://hg.mozilla.org/mozilla-central/rev/a9e860d35d5b

Comment 10

[Daosheng Mu[:daoshengmu]]

We should consider to use OVR_multiview_multisampled_render_to_texture [1] for our multiview rendering support that works for MSAA framebuffer.

[1] https://www.khronos.org/registry/OpenGL/extensions/OVR/OVR_multiview_multisampled_render_to_texture.txt

Comment 11

[Kelsey Gilbert [:jgilbert]]

(In reply to Daosheng Mu[:daoshengmu] from comment #10)

We should consider to use OVR_multiview_multisampled_render_to_texture [1] for our multiview rendering support that works for MSAA framebuffer.

[1] https://www.khronos.org/registry/OpenGL/extensions/OVR/OVR_multiview_multisampled_render_to_texture.txt

File a bug.

Comment 12

[Florian Scholz (Open Web Docs)]

See https://bugzilla.mozilla.org/show_bug.cgi?id=1583878#c6 for documentation work.