153679 - ASSERTION: aWidgetView must have a widget

Status: RESOLVED FIXED

(Core :: Web Painting, defect, P3)

Description

[Bernd]

I think the change for bug 124685 has caused the following regression in the
layout regression tests. There are now a whole bunch of assertions:

###!!! ASSERTION: aWidgetView must have a widget: 'nsnull != widget', file
./nsViewManager.cpp, line 1511

You can trigger these assertions by going to the URL and printing it.

May be you should run those tests....

Comment 1

[Robert O'Callahan (:roc) (email my personal email if necessary)]

The assertion should be removed. It's firing because, during printing, someone
is trying to either invalidate or scroll a view. This isn't really wrong because
invalidates are really just no-ops and scrolling is sometimes necessary during
printing (e.g., to make the current selection show up in a list box). I've
double-checked the callers of UpdateWidgetArea and they're not going to pass in
a view without a widget except during printing.

Comment 2

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Attachment: obvious fix

Comment 3

[Robert O'Callahan (:roc) (email my personal email if necessary)]

*** Bug 170322 has been marked as a duplicate of this bug. ***

Comment 4

[Roland Mainz]

Marking OS/Platform==All/All per DUPlicate bug 170322 ...

Comment 5

[Roland Mainz]

Comment on attachment 101862 [details] [diff] [review]
obvious fix

r=[e-mail]

Comment 6

[kinmoz]

Comment on attachment 101862 [details] [diff] [review]
obvious fix

sr=[e-mail]

Do we want to add a comment that notes when this situation can happen?

Comment 7

[Robert O'Callahan (:roc) (email my personal email if necessary)]

Sure, I'll do that.

Comment 8

[Robert O'Callahan (:roc) (email my personal email if necessary)]

fix checked in.