1536800 - Pinned tab isn't restored on restart

Status: RESOLVED DUPLICATE of bug 1543684

(Firefox :: Session Restore, defect, P5)

Description

[Carol Nichols]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:68.0) Gecko/20100101 Firefox/68.0

Steps to reproduce:

Tested with Firefox 68.0a1 (2019-03-19) (64-bit) on macOS Mojave 10.14.3 (18D109)

• Open a tab to an IP address, either local (192...*) or remote
• Pin that tab
• Also have other pinned tabs that have URLs as their address
• Restart Firefox (either through the nightly "Restart to update nightly" in the menu bar or by quitting Firefox and restoring session)

Actual results:

Only the pinned tabs that have URLs as their addresses are restored; the pinned tabs with IP addresses are not restored either as pinned or unpinned tabs.

Expected results:

I expected all my pinned tabs, whether they're to URLs or IP addresses, to be restored. I don't mind if the IP address tabs don't load (for example, when I'm not on my LAN), I just always want those tabs there for when they can load. I realize this might be a feature, but it's not what I expected.

Comment 1

[Carol Nichols]

If I edit my hosts file to give the IP address a URL, I'm able to work around this problem and pin that URL.

Comment 2

[Mike de Boer [:mikedeboer]]

Hi Carol, thanks for filing and apology for the late reply! I'm afraid that I'm unable to reproduce this issue. I see that you're using a Nightly version - but can you check with a more recent one to try if you can still reproduce it and if so, perhaps narrow down the steps to reproduce for me?
Also a copy of your about:support might help. Thanks!

Comment 3

[Carol Nichols]

Hi Mike! This issue is very intermittent... and since I filed this, I don't think it's related to an IP address being pinned, because I'm now exclusively using a definition in my hosts file and it's still happening.

I tried to capture the bug on video, and I caught one of the manifestations: https://youtu.be/IqDVzR85F2k I'm pretty sure there's nothing private in the video, but I'll probably take it down when you're done with it.

Here's what you'll see in the video:

• I have 4 pinned tabs and 4 non-pinned tabs. One of the 4 pinned tabs is to vivian.local, the address configured in my hosts file to a local IP address only accessible on my network.
• I use the "Restart to update nightly" in the upper right.
• I get "Sorry. We're having trouble getting your pages back". This happens occasionally when I restart, but usually I don't see this page, it just loses some of my tabs.
• The "View previous tabs" on the restore session screen shows 3 pinned tabs and 0 non-pinned tabs.
• I click the "restore session" button.
• Firefox restores the 3 pinned tabs and 0 non-pinned tabs.
• I go to the "History" menu and choose "Restore previous session", which restores 3 non-pinned tabs that were from a few days ago. This is weird that this previous session is different than the one found during restart o.O
• I close the new 3 non-pinned tabs
• I open a new tab to vivian.local again
• I open a new tab to grab the about:support info
• I pinned the vivian.local tab that I really want to have pinned and stay pinned but firefox really doesn't want me to pin
• I now have 4 pinned tabs and 1 unpinned tab
• Nightly wants to restart again, so I do
• This time, Firefox correctly restores the 4 pinned tabs and 1 non-pinned tab
• I grabbed the about:support info again

I've attached the about:support info from before the video, after the first restart, and after the second restart.

I'll try and remember to capture my screen before every time I restart to get the other manifestation I see most often, which is firefox doesn't say it had a problem restoring tabs but just loses one of my pinned tabs.

Comment 4

[Carol Nichols]

Attachment: firefox-about-support.txt

Comment 5

[Mike de Boer [:mikedeboer]]

Hi Carol, thanks much for the video and detailed commentary! This is much more than I hoped for - and usually get in reply - much much appreciated! :)

Good news is that I know what's going on here, and I'm planning to fix it in bug 1543684. You're going to be cc'd to that one automatically, so you can follow along there.

Comment 6

[Carol Nichols]

Great! Thank you so much! <3