1537596 - Shift-clicking line-breakpoint does not toggle all enabled column breakpoints

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P2)

Description

[Jason Laster [:jlast]]

Follow up on #7241: Review Critical Path Interactions

STR:

• Enable multiple column breakpoints on a line
• Shift-click the line breakpoints

AR: Only the first column breakpoint gets toggled
ER: All enabled column breakpoints get disabled and on second click enabled again

CC https://github.com/firefox-devtools/debugger/issues/8105

Comment 1

[David Walsh :davidwalsh]

Attachment: Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth

Implements a function to enable or disable all breakpoints on a line based on shift-clicking. Uses the first breakpoint's state to decide whether to enable or disable all.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a1c5e97960d0
Make shift-click toggle all breakpoint states per line r=loganfsmyth

Comment 3

[Andrei Ciure[:aciure]]

Backed out changeset a1c5e97960d0 (bug 1537596) for causing debugger test perma failure

push that caused the backout: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&selectedJob=235328305&revision=a1c5e97960d018765655172190d7661c89039694

failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=testfailed%2Cbusted%2Cexception&classifiedState=unclassified&fromchange=d66a126be7b677ef148dd30f20371a212fece804&selectedJob=235379053&searchStr=linux%2Cx64%2Copt%2Cnode%2Ctests%2Csource-test-node-debugger-tests%2Cnode%28debugger%29

backout: https://hg.mozilla.org/integration/autoland/rev/2c4f799e65b2fad5790d8edd549bf69ba6248301

Comment 4

[David Walsh :davidwalsh]

Attachment: Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth

Implements a function to enable or disable all breakpoints on a line based on shift-clicking. Uses the first breakpoint's state to decide whether to enable or disable all.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/df4ac1d02ea4
Make shift-click toggle all breakpoint states per line r=loganfsmyth

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/df4ac1d02ea4

Comment 7

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/df4ac1d02ea412b3a485125efeaaeb0b2fd3c942
Bug 1537596 - Make shift-click toggle all breakpoint states per line r=loganfsmyth