1537648 - Unlabelled button in Firefox Accounts menu

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[James Teh [:Jamie]]

STR (with a screen reader):

1. Ensure you're signed into a verified Firefox account.
2. Press control+l to focus the Location bar.
3. Tab to the group of toolbar buttons containing the Firefox Accounts button and then press right arrow until Firefox Accounts is focused.
4. Press space to activate it. If bug 1537647 isn't fixed yet, press tab to focus the first button.
   • Expected: A label should be reported for the focused button.
   • Actual: only the fact that this is a button is reported. There is no label.

(I would have given STR for the A11y Inspector, but I'm not sure how to provide STR using that since the panel will disappear if you try to switch to the Browser Toolbox.)

I'm guessing this is this button here:
https://searchfox.org/mozilla-central/source/browser/components/customizableui/content/panelUI.inc.xul#741

Comment 1

[:Gijs (he/him)]

The button is for changing the avatar. The question I'm not sure about is whether it makes sense to label for that action (we don't really make it obvious to sighted users that this is a button - it doesn't look like one (AIUI deliberately), has no hover effect, etc.). Visually, the button contains the avatar (account image) of the user's signed in account. Right next to it there is some "Signed in as [e-mail]" text (ie https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/browser/components/customizableui/content/panelUI.inc.xul#744-747 ) - is that currently accessible? Would it make sense to use that as the label?

The other complicating factor here is that ideally we should reuse existing strings because people want this uplifted to 67...

I suspect that the "right" thing to do would be to add a label for the button that reflects that it lets you change the account's picture, and use the "Signed in as" as an aria description/label for the entire panel or something? But I'm not sure how easy it is to do that...

Comment 2

[:Gijs (he/him)]

(In reply to James Teh [:Jamie] from comment #0)

(I would have given STR for the A11y Inspector, but I'm not sure how to provide STR using that since the panel will disappear if you try to switch to the Browser Toolbox.)

There's a dropdown option in the meat ball menu in the browser toolbox to disable popup auto hide which would stop the popup disappearing, in case that's helpful.

Comment 3

[James Teh [:Jamie]]

(In reply to :Gijs (he/him) from comment #1)

The button is for changing the avatar. The question I'm not sure about is whether it makes sense to label for that action (we don't really make it obvious to sighted users that this is a button - it doesn't look like one (AIUI deliberately), has no hover effect, etc.). Visually, the button contains the avatar (account image) of the user's signed in account.

How would a sighted user know that clicking it would allow them to change their avatar (as opposed to doing nothing or visiting something else account related)? Is that just a common trend that users have come to expect? It seems like a discoverability problem.

Right next to it there is some "Signed in as [e-mail]" text (ie https://searchfox.org/mozilla-central/rev/7c20ad925005fbad7b8e08813115f1ec7fa1c248/browser/components/customizableui/content/panelUI.inc.xul#744-747 ) - is that currently accessible?

It's exposed in the tree, but most screen reader users wouldn't find it because it isn't keyboard navigable and screen readers don't use browse mode here.

Would it make sense to use that as the label?

I'd prefer it be the description of the button, but see below.

The other complicating factor here is that ideally we should reuse existing strings because people want this uplifted to 67...

Yeah, that does make things tricky. In the short term (so we can get this uplifted), I think it'd be acceptable to aria-labelledby the button with the "Signed in as" info. In future (68?), I'd prefer the button have a (aria-)label indicating that it changes the avatar and have the "Signed in as" as the button's aria-describedby. I still wonder whether this is a discoverability problem for sighted users, though. Could we make the action tooltiptext?

Comment 4

[Vijay Budhram]

Attachment: Bug 1537648 - remove change avatar button from FxA menu

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b255e2562c96
remove change avatar button from FxA menu r=Gijs

Comment 6

[Stefan Hindli [:stefan_hindli]]

https://hg.mozilla.org/mozilla-central/rev/b255e2562c96

Comment 7

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/b255e2562c9648616121ba7a167449430452895b
Bug 1537648 - remove change avatar button from FxA menu r=Gijs

Comment 8

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/releases/mozilla-beta/rev/f83ea1d76d6e

Comment 9

[Vlad Lucaci, Thunderbird QA (:vlucaci)]

Hello,

Managed to reproduce this issue with the build from 2019-03-20 68.0a1(20190320112939).

Confirming this issue as verified fixed Nightly 68.0a1 (2019-05-09) and the latest Beta 67.0b18 on Windows 10x64 and Ubuntu 16.04.