1537947 - The avatar icon in the Firefox Accounts menu is not centered horizontally (seen esp. in its hover state)

Status: VERIFIED FIXED

(Firefox :: Firefox Accounts, defect)

Description

[Itiel]

Attachment: Screenshot

See attached.
I'm not sure if the icon is misaligned, or if the hover state is a bit off..

Comment 1

[:Gijs (he/him)]

There shouldn't be any hover state.

What OS are you seeing this on?

Comment 2

[Itiel]

(In reply to :Gijs (he/him) from comment #1)

There shouldn't be any hover state.

Why not? Clicking it takes me here (see attached) where I can upload an image.

What OS are you seeing this on?

Windows 10.

Comment 3

[Itiel]

Attachment: Upload image screenshot

Comment 4

[Itiel]

(In reply to Itiel from comment #2)

(In reply to :Gijs (he/him) from comment #1)

There shouldn't be any hover state.

Why not? Clicking it takes me here (see attached) where I can upload an image.

Oh, unless you meant that there shouldn't be any visual change when I hover it, but it still should redirect me to the Firefox Accounts page?

Comment 5

[:Gijs (he/him)]

(In reply to Itiel from comment #4)

Oh, unless you meant that there shouldn't be any visual change when I hover it, but it still should redirect me to the Firefox Accounts page?

Yes. At least, that's what I think the intent is. Ryan/Bryan?

Comment 6

[Ryan Feeley [:rfeeley]]

Let's remove the link on the avatar entirely. We may return it in future but will change the icons a bit so that users know that clicking it will add an icon if one is not set, or edit the icon if one is (likely by insetting a + or ✎ icon respectively).

Comment 7

[:Gijs (he/him)]

Itiel, can you check on today's nightly if this resolves the issue, or if there's an additional adjustment we need to make to the margin in RTL to make it match LTR?

Comment 8

[:Gijs (he/him)]

Sorry, and by "this" I meant bug 1537648 being fixed. :-)

Comment 9

[Itiel]

LGTM. I don't see any RTL issue with this popup ATM and there's no hover state now. Thanks!