1537667 - allow the 'layout.display-list.retain' pref to work on android

Status: RESOLVED FIXED

(Core :: Web Painting, enhancement)

Comment 1

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1537667. Allow the 'layout.display-list.dump' pref to work on android. r?mattwoodrow

Fennec isn't e10s, so neither existing check worked.

Comment 2

[Kartikaya Gupta (email:[e-mail])]

Wrong pref name (for bug summary and commit message)?

Comment 3

[Timothy Nikkel (:tnikkel)]

(In reply to Kartikaya Gupta (email:[e-mail]) from comment #2)

Wrong pref name (for bug summary and commit message)?

Ooops, copy paste fail. I'll fix. Thanks.

Comment 4

[Timothy Nikkel (:tnikkel)]

Attachment: Bug 1537667. Allow the 'layout.display-list.retain' pref to work on android. r?mattwoodrow

Fennec isn't e10s, so neither existing check worked.

https://phabricator.services.mozilla.com/D24310

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4f607065a97f
Allow the 'layout.display-list.retain' pref to work on android. r=mattwoodrow

Comment 6

[Andreea Pavel [:apavel]]

https://hg.mozilla.org/mozilla-central/rev/4f607065a97f

Comment 7

[csheany]

Should the value be set to true in about:config?

Comment 8

[Timothy Nikkel (:tnikkel)]

(In reply to csheany from comment #7)

Should the value be set to true in about:config?

No. This bug is just allowing the pref to actually work on android. Before this patch flipping the pref had no effect.

Comment 9

[csheany]

Thank you for your response.

Is there a bug to follow for when it will be enabled on Nightly?

Is Bug 1413567 about release?

Does it require restarting?

Is this a relevant article (https://hacks.mozilla.org/2018/06/retained-display-lists)?

Comment 10

[Timothy Nikkel (:tnikkel)]

(In reply to csheany from comment #9)

Is there a bug to follow for when it will be enabled on Nightly?
Is Bug 1413567 about release?

I'll either use that bug or a bug that depends on that bug.

Does it require restarting?

It looks like it's a live pref, but I would restart just to be sure.

Is this a relevant article
(https://hacks.mozilla.org/2018/06/retained-display-lists)?

Yes, that enabled for android.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/35a116fe36f5
Remove stray semicolon.

Comment 12

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/35a116fe36f5

Comment 13

[Julien Cristau [:jcristau]]

This is in the 68.0beta android release notes as "Improved web page painting performance by avoiding redundant calculations during paint".

Comment 14

[Timothy Nikkel (:tnikkel)]

(In reply to Julien Cristau [:jcristau] from comment #13)

This is in the 68.0beta android release notes as "Improved web page painting
performance by avoiding redundant calculations during paint".

Not sure if it matters, but the proper bug is bug 1413567.

This bug only made it so that the pref had an effect if you flipped it on android. We actually flipped the pref in bug 1413567.

Comment 15

[Julien Cristau [:jcristau]]

Thanks. (It's not a big deal, the bug association is not visible on the website, but I'll move this.)