1537934 - Remove Custom Element "Download" and Integrate it in the callsite.

Status: RESOLVED FIXED

(Thunderbird :: General, task)

Comment 1

[Magnus Melin [:mkmelin]]

Please always provide context for bugs, and reference if there is one, like here "see bug 1525589 comment 20". If someone follows the bug now they should be given the story of what and why. The same if someone comes back later to revisit this thing for whatever reasons.

So, in bug 1525589 we converted the download binding into custom element. The usage is however small, and it should be possible to easily just do it all inline in JavaScript instead.

Comment 2

[Khushil Mistry [:khushil324]]

Attachment: Bug-1537934_remove-download-view-item.patch

Comment 3

[Magnus Melin [:mkmelin]]

Comment on attachment 9059568 [details] [diff] [review]
Bug-1537934_remove-download-view-item.patch

Review of attachment 9059568 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, r=mkmelin

Comment 4

[Khushil Mistry [:khushil324]]

There is some test failure. I have updated the patch and put it on a try server. Will update patch over here in a while.

Comment 5

[Khushil Mistry [:khushil324]]

Attachment: Bug-1537934_remove-downloads-view-item.patch

https://treeherder.mozilla.org/#/jobs?repo=try-comm-central&revision=834a4c76bcf8e13529142456ff1b2f46f50d16de

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/09c7302e2d67
Remove custom element 'Download' and integrate it into the callsite. r=mkmelin