Closed
Bug 1537990
Opened 6 years ago
Closed 6 years ago
Use raw HTTPS connection for simple conduit API, instead of `arc call-conduit`
Categories
(Conduit :: moz-phab, enhancement, P2)
Conduit
moz-phab
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: arai, Assigned: arai)
References
Details
(Keywords: conduit-triaged)
Attachments
(2 files, 1 obsolete file)
arc_call_conduit [1] should be easily replaced with simple HTTPS request.
I'd like to do that part as a first step removing arc dependency.
[1] https://github.com/arai-a/review/blob/d255b1cdb46e2472f35fb7b20cf19b6990b05e03/moz-phab#L2147-L2179
| Assignee | ||
Comment 1•6 years ago
|
||
| Assignee | ||
Comment 2•6 years ago
|
||
updated to keep using arc_ping for now, in parallel with conduit_ping for raw connection
https://github.com/arai-a/review/commits/raw-conduit
Keywords: conduit-triaged
Priority: -- → P2
Comment 3•6 years ago
|
||
Hi arai, do you want to continue on the development of this patch?
Flags: needinfo?(arai.unmht)
| Assignee | ||
Comment 4•6 years ago
|
||
Yes, I forgot to mention that I was testing this patch to post my other patches for a while.
I'll submit the patch shortly.
Flags: needinfo?(arai.unmht)
| Assignee | ||
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
After rebasing few of the tests were not working.
We do read more from get_revisions which is now using repo.call_conduit.
Depends on D32125
Comment 7•6 years ago
|
||
Updated•6 years ago
|
Attachment #9070262 -
Attachment description: Bug 1537990 - WIP refactor Conduit out of the Repository → Bug 1537990 - Refactor Conduit API out of the Repository class
Updated•6 years ago
|
Attachment #9070262 -
Attachment description: Bug 1537990 - Refactor Conduit API out of the Repository class → Bug 1537990 - Refactor Conduit API out of the Repository class r=glob!
Updated•6 years ago
|
Attachment #9069307 -
Attachment is obsolete: true
Updated•6 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•