Closed Bug 1538158 Opened 5 months ago Closed 5 months ago

Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL

Categories

(Firefox :: Address Bar, defect, P3)

x86_64
Windows 10
defect
Points:
2

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: gcp, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Attached image awescreenshot.png

Note: I seem to be in the Quantumbar experiment:
app.normandy.startupExperimentPrefs.browser.urlbar.quantumbar true
browser.urlbar.quantumbar true

When going to a website, say lichess.org, and clicking the history drop-down, it will only show hits on the same site. (This is never what I want, as I can filter sites easily by typing anyway, but not undo the filter by typing!)

This is a regression from previous behavior, where the history drop-down would shows entries from all sites listed by frecency.

I bisected this to a commit that seems entirely unrelated:

8:41.25 INFO: No more inbound revisions, bisection finished.
8:41.26 INFO: Last good revision: b179bb22821b9311b1824e725abdc945ab3f57f4
8:41.26 INFO: First bad revision: cbb4720dc4d5c4f782943a888a4e4ed05320134c
8:41.26 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b179bb22821b9311b1824e725abdc945ab3f57f4&tochange=cbb4720dc4d5c4f782943a888a4e4ed05320134c

https://bugzilla.mozilla.org/show_bug.cgi?id=1515307

Blocks: 1515307

Ok, so apparently the behavior between pressing down and the dropdown button differs in the awesomebar, down searches for the typed string, but the dropdown button instead always considers an empty string search.

Priority: -- → P3
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Summary: Awesomebar history drop down only considers the current site → Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/827a1c12a137
Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL. r=adw
Points: --- → 2
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/98fddb0a076a
Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL. r=adw
Flags: needinfo?(dao+bmo)
Status: ASSIGNED → RESOLVED
Closed: 5 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68

The behavior still looks wrong to me, if I click on the urlbar and press down, I'd expect the search to refer to the current url. If I click on the dropmarker instead, I expect it to do the empty string search. This is what the legacy urlbar does.

What I see in current Nightly is that when I press down on the current url we run the empty search.

Blocks: 1540662
No longer blocks: 1540710
Regressions: 1540710
You need to log in before you can comment on or make changes to this bug.