1538158 - Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Gian-Carlo Pascutto [:gcp]]

Attachment: awescreenshot.png

Note: I seem to be in the Quantumbar experiment:
app.normandy.startupExperimentPrefs.browser.urlbar.quantumbar true
browser.urlbar.quantumbar true

When going to a website, say lichess.org, and clicking the history drop-down, it will only show hits on the same site. (This is never what I want, as I can filter sites easily by typing anyway, but not undo the filter by typing!)

This is a regression from previous behavior, where the history drop-down would shows entries from all sites listed by frecency.

I bisected this to a commit that seems entirely unrelated:

8:41.25 INFO: No more inbound revisions, bisection finished.
8:41.26 INFO: Last good revision: b179bb22821b9311b1824e725abdc945ab3f57f4
8:41.26 INFO: First bad revision: cbb4720dc4d5c4f782943a888a4e4ed05320134c
8:41.26 INFO: Pushlog:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=b179bb22821b9311b1824e725abdc945ab3f57f4&tochange=cbb4720dc4d5c4f782943a888a4e4ed05320134c

https://bugzilla.mozilla.org/show_bug.cgi?id=1515307

Comment 1

[Marco Bonardo [:mak]]

Ok, so apparently the behavior between pressing down and the dropdown button differs in the awesomebar, down searches for the typed string, but the dropdown button instead always considers an empty string search.

Comment 2

[Dão Gottwald [:dao]]

Attachment: Bug 1538158 - Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL. r=Standard8,adw

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/827a1c12a137
Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL. r=adw

Comment 4

[Cristian Brindusan [:cbrindusan]]

Backed out changeset 827a1c12a137 (Bug 1538158) for bc failures at browser_action_searchengine.js.

Backout: https://hg.mozilla.org/integration/autoland/rev/db92f218cea95be1596b1be70ccb80db7024eae7

Push that started the failures: https://treeherder.mozilla.org/#/jobs?repo=autoland&resultStatus=pending%2Crunning%2Csuccess%2Ctestfailed%2Cbusted%2Cexception&revision=827a1c12a137e05172d6f24c509ad9acc62035c0&selectedJob=236583813

Failure log: https://treeherder.mozilla.org/logviewer.html#/jobs?job_id=236583813&repo=autoland&lineNumber=2997

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/98fddb0a076a
Clicking the history dropmarker should initiate an empty search instead of searching for the loaded URL. r=adw

Comment 6

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/98fddb0a076a

Comment 7

[Marco Bonardo [:mak]]

The behavior still looks wrong to me, if I click on the urlbar and press down, I'd expect the search to refer to the current url. If I click on the dropmarker instead, I expect it to do the empty string search. This is what the legacy urlbar does.

What I see in current Nightly is that when I press down on the current url we run the empty search.

Comment 8

[Marco Bonardo [:mak]]

I filed bug 1540710 to track comment 7.