1540662 - UITour isn't starting an address bar search properly with QuantumBar enabled

Status: RESOLVED FIXED

(Firefox :: Tours, enhancement, P2)

Description

[Mark Banner (:standard8)]

I picked this up in a test run with QuantumBar enabled:

TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_showMenu.js | Search string is Firefox - Got , expected Firefox

It looks like bug 1529931 changed how startQuery works, so we now have to either ensure pageproxystate is invalid (which normally happens if the user typed something - input event), or supply a parameter to startQuery.

I think given setting pageproxystate is closest to what happens when the user types something, we shold do that.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1540662 - Fix the UITour starting an address bar search with QuantumBar enabled. r?mak

Set 'pageproxystate' to invalid as it would be if the user typed the entry.

Comment 2

[Marco Bonardo [:mak]]

(In reply to Mark Banner (:standard8) from comment #0)

It looks like bug 1529931 changed how startQuery works

Did you mean bug 1538158?

Comment 3

[Mark Banner (:standard8)]

(In reply to Marco Bonardo [::mak] from comment #2)

(In reply to Mark Banner (:standard8) from comment #0)

It looks like bug 1529931 changed how startQuery works

Did you mean bug 1538158?

Ah yes, looks like it.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/157c5b2beb40
Fix the UITour starting an address bar search with QuantumBar enabled. r=mak

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/157c5b2beb40