Closed Bug 1540662 Opened 8 months ago Closed 8 months ago

UITour isn't starting an address bar search properly with QuantumBar enabled

Categories

(Firefox :: Tours, enhancement, P2)

enhancement
Points:
1

Tracking

()

RESOLVED FIXED
Firefox 68
Tracking Status
firefox68 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

(Whiteboard: [fxsearch])

Attachments

(1 file)

I picked this up in a test run with QuantumBar enabled:

TEST-UNEXPECTED-FAIL | browser/components/uitour/test/browser_showMenu.js | Search string is Firefox - Got , expected Firefox

It looks like bug 1529931 changed how startQuery works, so we now have to either ensure pageproxystate is invalid (which normally happens if the user typed something - input event), or supply a parameter to startQuery.

I think given setting pageproxystate is closest to what happens when the user types something, we shold do that.

Set 'pageproxystate' to invalid as it would be if the user typed the entry.

(In reply to Mark Banner (:standard8) from comment #0)

It looks like bug 1529931 changed how startQuery works

Did you mean bug 1538158?

(In reply to Marco Bonardo [::mak] from comment #2)

(In reply to Mark Banner (:standard8) from comment #0)

It looks like bug 1529931 changed how startQuery works

Did you mean bug 1538158?

Ah yes, looks like it.

Depends on: 1538158
No longer depends on: 1529931
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/157c5b2beb40
Fix the UITour starting an address bar search with QuantumBar enabled. r=mak
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
You need to log in before you can comment on or make changes to this bug.