1538511 - Extract nsIScrollableFrame::ScrollMode into its own file

Status: RESOLVED FIXED

(Core :: Layout: Scrolling and Overflow, enhancement)

Description

[Botond Ballo [:botond]]

As suggested in this review comment, we should extract nsIScrollableFrame::ScrollMode into its own file, and use it in nsIPresShell.h instead of defining a separate enumeration there.

Comment 1

[Kartikaya Gupta (email:[e-mail])]

(Also it doesn't necessarily need to go into its own file, it could go into some other file that can be included into all the other places it needs to be used)

Comment 2

[Botond Ballo [:botond]]

Attachment: Bug 1538511 - Move nsIScrollableFrame::ScrollMode into a separate file. r=kats

This allows this enumeration to be used from nsIPresShell.h without introducing
a circular dependency.

Its new home in layout/base/ScrollTypes.h, included as mozilla/ScrollTypes.h.
Others similar enums can be added to that file if desired.

This patch also makes ScrollMode an enum class (as it's no longer nested
inside a class) and switches its enumerators to the |eName| naming convention.

Comment 3

[Botond Ballo [:botond]]

Attachment: Bug 1538511 - Get rid of nsIPresShell::ScrollMode (use mozilla::ScrollMode instead). r=kats

Depends on D24796

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1538511 - Remove non-ASCII characters from comments in Element.cpp. r=kats

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/be9d79b76e1c
Remove non-ASCII characters from comments in Element.cpp. r=kats
https://hg.mozilla.org/integration/autoland/rev/57847959cfa6
Move nsIScrollableFrame::ScrollMode into a separate file. r=kats
https://hg.mozilla.org/integration/autoland/rev/5840b7d8521a
Get rid of nsIPresShell::ScrollMode (use mozilla::ScrollMode instead). r=kats

Comment 6

[Noemi Erli[:noemi_erli]]

.

Comment 7

[Botond Ballo [:botond]]

Wrong bug number.

Comment 8

[Oana Pop-Rus]

https://hg.mozilla.org/mozilla-central/rev/be9d79b76e1c
https://hg.mozilla.org/mozilla-central/rev/57847959cfa6
https://hg.mozilla.org/mozilla-central/rev/5840b7d8521a