1531535 - Add a smooth scrolling option to nsIDOMWindowUtils.scrollToVisual()

Status: RESOLVED FIXED

(Core :: Panning and Zooming, enhancement, P3)

Description

[Randall Barker [:rbarker]]

Currently nsIDOMWindowUtils.scrollToVisual() only supports auto scrolling. In order to support GeckoView API scrollTo() API, a smooth scrolling option needs to be added.

Comment 1

[Chris Peterson [:cpeterson]]

David says GV wants this feature for Fire TV scrolling. He's going to talk to Jessie and Botond about it.

Comment 2

[David Bolter [:davidb] (NeedInfo me for attention)]

Hi Botond, (per bug 1531531 comment 5) just adding a NI to go with my email from earlier today so that this doesn't fall through the cracks.

Comment 3

[Botond Ballo [:botond]]

To clarify: this bug is only needed to ensure that bug 1516056 doesn't regress Fire TV scrolling.

I'm going to block the landing of bug 1516056 on this bug. That way, Fire TV scrolling will not regress even temporarily.

Comment 4

[Botond Ballo [:botond]]

Attachment: Bug 1531535 - Extract an ApzSmoothScrollTo() helper function. r=kats

Comment 5

[Botond Ballo [:botond]]

Attachment: Bug 1531535 - Add visual smooth scroll support to nsIPresShell. r=kats

This patch renames nsIPresShell::SetPendingVisualScrollUpdate() to
ScrollToVisual(), and adds an instant vs. smooth option.

SetPendingVisualScrollUpdate() still exists, as a helper for the instant case.

Depends on D24552

Comment 6

[Botond Ballo [:botond]]

Attachment: Bug 1531535 - Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats

Depends on D24553

Comment 7

[Botond Ballo [:botond]]

Attachment: Bug 1531535 - Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats

Depends on D24554

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9fde8244e2c4
Extract an ApzSmoothScrollTo() helper function. r=kats
https://hg.mozilla.org/integration/autoland/rev/3d7514ac25e9
Add visual smooth scroll support to nsIPresShell. r=kats
https://hg.mozilla.org/integration/autoland/rev/82494837af14
Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats
https://hg.mozilla.org/integration/autoland/rev/a042ff02440e
Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats

Comment 9

[Daniel Varga [:dvarga]]

https://hg.mozilla.org/mozilla-central/rev/9fde8244e2c4
https://hg.mozilla.org/mozilla-central/rev/3d7514ac25e9
https://hg.mozilla.org/mozilla-central/rev/82494837af14
https://hg.mozilla.org/mozilla-central/rev/a042ff02440e

Comment 10

[Peter Van der Beken [:peterv]]

https://hg.mozilla.org/projects/ash/rev/9fde8244e2c45c29b4ccad390173539f3c890836
Bug 1531535 - Extract an ApzSmoothScrollTo() helper function. r=kats

https://hg.mozilla.org/projects/ash/rev/3d7514ac25e949e710a4cb597381207d7cc06c9c
Bug 1531535 - Add visual smooth scroll support to nsIPresShell. r=kats

https://hg.mozilla.org/projects/ash/rev/82494837af145a36241ea46ea12dcd1c76945131
Bug 1531535 - Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats

https://hg.mozilla.org/projects/ash/rev/a042ff02440e847199e709890db857b3c1bc7312
Bug 1531535 - Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats

Comment 11

[Chris Peterson [:cpeterson]]

67=wontfix because we don't need to uplift this fix to GV 67 Beta if it's not needed for Fenix MVP.

Comment 12

[Botond Ballo [:botond]]

I'm not sure why you need this on ash, but if you're actually using it, you probably also want bug 1539687 which fixes a bug in this.

Comment 13

[Peter Van der Beken [:peterv]]

Ignore comment 10. That was just a regular merge, but I didn't disable the bzpost hook for it.