Closed Bug 1531535 Opened 6 months ago Closed 5 months ago

Add a smooth scrolling option to nsIDOMWindowUtils.scrollToVisual()

Categories

(Core :: Panning and Zooming, enhancement, P3)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox65 --- wontfix
firefox66 --- wontfix
firefox67 --- wontfix
firefox68 --- fixed

People

(Reporter: rbarker, Assigned: botond)

References

Details

(Whiteboard: [gvtv:p2] [geckoview:p2])

Attachments

(4 files)

Currently nsIDOMWindowUtils.scrollToVisual() only supports auto scrolling. In order to support GeckoView API scrollTo() API, a smooth scrolling option needs to be added.

Blocks: 1531531

David says GV wants this feature for Fire TV scrolling. He's going to talk to Jessie and Botond about it.

Whiteboard: [gvtv]

Hi Botond, (per bug 1531531 comment 5) just adding a NI to go with my email from earlier today so that this doesn't fall through the cracks.

Flags: needinfo?(botond)
Whiteboard: [gvtv] → [gvtv:p2] [geckoview:p2]
Blocks: 1516056

To clarify: this bug is only needed to ensure that bug 1516056 doesn't regress Fire TV scrolling.

I'm going to block the landing of bug 1516056 on this bug. That way, Fire TV scrolling will not regress even temporarily.

Flags: needinfo?(botond)
Assignee: nobody → botond

This patch renames nsIPresShell::SetPendingVisualScrollUpdate() to
ScrollToVisual(), and adds an instant vs. smooth option.

SetPendingVisualScrollUpdate() still exists, as a helper for the instant case.

Depends on D24552

Blocks: 1538511
Attachment #9052962 - Attachment description: Bug 1531535 - Extract az ApzSmoothScrollTo() helper function. r=kats → Bug 1531535 - Extract an ApzSmoothScrollTo() helper function. r=kats
Pushed by bballo@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/9fde8244e2c4
Extract an ApzSmoothScrollTo() helper function. r=kats
https://hg.mozilla.org/integration/autoland/rev/3d7514ac25e9
Add visual smooth scroll support to nsIPresShell. r=kats
https://hg.mozilla.org/integration/autoland/rev/82494837af14
Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats
https://hg.mozilla.org/integration/autoland/rev/a042ff02440e
Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats
Blocks: 1539687
https://hg.mozilla.org/projects/ash/rev/9fde8244e2c45c29b4ccad390173539f3c890836
Bug 1531535 - Extract an ApzSmoothScrollTo() helper function. r=kats

https://hg.mozilla.org/projects/ash/rev/3d7514ac25e949e710a4cb597381207d7cc06c9c
Bug 1531535 - Add visual smooth scroll support to nsIPresShell. r=kats

https://hg.mozilla.org/projects/ash/rev/82494837af145a36241ea46ea12dcd1c76945131
Bug 1531535 - Use the visual smooth scrolling API in nsDocShell::SetCurScrollPosEx() if appropriate. r=kats

https://hg.mozilla.org/projects/ash/rev/a042ff02440e847199e709890db857b3c1bc7312
Bug 1531535 - Expose the ability to do a visual smooth scroll in nsIDOMWindowUtils. r=kats

67=wontfix because we don't need to uplift this fix to GV 67 Beta if it's not needed for Fenix MVP.

I'm not sure why you need this on ash, but if you're actually using it, you probably also want bug 1539687 which fixes a bug in this.

Flags: needinfo?(peterv)

Ignore comment 10. That was just a regular merge, but I didn't disable the bzpost hook for it.

Flags: needinfo?(peterv)
You need to log in before you can comment on or make changes to this bug.