1538589 - [css-pseudo] ::marker layout isn't updated after dynamic 'class' change

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P3)

Description

[Mats Palmgren (inactive)]

Follow-up from bug 205202 comment 43:

> ::: layout/base/RestyleManager.cpp
> @@ +2718,5 @@
> > +        !nsLayoutUtils::GetMarkerPseudo(aElement)) {
> > +      RefPtr<ComputedStyle> pseudoStyle =
> > +          aRestyleState.StyleSet().ProbePseudoElementStyle(
> > +              *aElement, PseudoStyleType::marker, styleFrame->Style());
> > +      if (pseudoStyle) {
> 
> The reason this doesn't work as you mentioned is because we're returning the
> cached style instead of computing it again.
> 
> So either make the marker pseudo uncacheable or, even better, pass the
> up-to-date parent style here. I think we shouldn't probe this all the time
> if the element wasn't restyled, so that needs a bit more work. Fine to leave
> as-is, I can fix as a followup.

Testcase:
https://bug205202.bmoattachments.org/attachment.cgi?id=9051388

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1538589 - Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52bda46586ef
Fix ::marker invalidation when we need to potentially insert a marker as a result of a style change. r=mats

Comment 3

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/52bda46586ef

Comment 4

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Created web-platform-tests PR https://github.com/web-platform-tests/wpt/pull/16259 for changes under testing/web-platform/tests