Closed Bug 1538987 Opened 7 months ago Closed 7 months ago

Collect Telemetry on process priority switching

Categories

(Core :: DOM: Content Processes, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox67 --- fixed
firefox68 --- fixed

People

(Reporter: mconley, Assigned: mconley)

References

Details

Attachments

(3 files)

We'd like to collect a count of how many times:

  1. We lower a process priority from normal to something else
  2. We bring a process priority back to normal

Edited to

  1. We lower a process priority from normal to something else
  2. We bring a process priority back to normal
  3. Total opportunities to change process priority (which in my head is equivalent to opening or switching tabs, correct me if i'm wrong)
Assignee: nobody → mconley
Attachment #9054044 - Flags: data-review?(chutten)

(In reply to "Saptarshi Guha[:joy]" from comment #1)

  1. Total opportunities to change process priority (which in my head is equivalent to opening or switching tabs, correct me if i'm wrong)

Yep, but also bringing a Firefox window up after having sent it into the background, etc...

Comment on attachment 9054044 [details]
Data review request

Redirecting to :tdsmith as he's a new Steward looking for review experience.
Attachment #9054044 - Flags: data-review?(chutten) → data-review?(tdsmith)
Comment on attachment 9054044 [details]
Data review request

A best practice, particularly for for indefinite collections, is to add automated tests that the probes are incremented under the expected conditions. The [TelemetryTestUtils](https://searchfox.org/mozilla-central/source/toolkit/components/telemetry/tests/utils/TelemetryTestUtils.jsm) may be useful!

data-review: r+

--

# Data Review Form

1) Is there or will there be **documentation** that describes the schema for the ultimate data set available publicly,
complete and accurate?

Yes, in Scalars.yaml.

2) Is there a control mechanism that allows the user to turn the data collection on and off?
Provide details as to the control mechanism available.

Yes, the telemetry opt-out.

3) If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, mconley and gsvelto.

4) Using the **[category system of data types](https://wiki.mozilla.org/Firefox/Data_Collection)** on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1.

5) Is the data collection request for default-on or default-off?

Default-on.

6) Does the instrumentation include the addition of **any *new* identifiers**?

No.

7) Is the data collection covered by the existing Firefox privacy notice?

Yes.

8) Does there need to be a check-in in the future to determine whether to renew the data?

No, indefinite collection.

9) Does the data collection use a third-party collection tool?

No.
Attachment #9054044 - Flags: data-review?(tdsmith) → data-review+

Thanks for the reviews!

I made the mistake of auto-landing before I put tdsmith's name in the commit message, so it says data-review=chutten, but it should say data-review=tdsmith. Sorry about that!

Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/7fff0ba3ac2a
Collect Telemetry on process priority switching. data-review=chutten, r=gsvelto
Status: NEW → RESOLVED
Closed: 7 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68

Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: None really, but it might delay the roll out of the Process Priority Manager feature for Windows because our data science team won't be able to validate it's behaviour.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): These are just some telemetry probes to help with an experiment we want to run on Beta.
  • String changes made/needed:
Attachment #9054039 - Flags: approval-mozilla-beta?

Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto

Dropping this - I've noticed a small issue with the probe where we'll increment the os_priority_raised probe every time we create a new tab. Investigating.

Attachment #9054039 - Flags: approval-mozilla-beta?

Re-opening this bug because I have a follow-up.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Pushed by mconley@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a64cb34bc073
Follow-up: skip incrementing the DOM_CONTENTPROCESS_OS_PRIORITY_RAISED probe for the initialization case. r=gsvelto
Status: REOPENED → RESOLVED
Closed: 7 months ago7 months ago
Resolution: --- → FIXED

Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto

Beta/Release Uplift Approval Request

  • Feature/Bug causing the regression: None
  • User impact if declined: None really, but it might delay the roll out of the Process Priority Manager feature for Windows because our data science team won't be able to validate it's behaviour.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): These are just some telemetry probes to help with an experiment we want to run on Beta.
  • String changes made/needed: None
  • Do you want to request approval of these patches as well?: on
Attachment #9054039 - Flags: approval-mozilla-beta?

Comment on attachment 9054561 [details]
Bug 1538987 - Follow-up: skip incrementing the DOM_CONTENTPROCESS_OS_PRIORITY_RAISED probe for the initialization case. r?gsvelto

See above.

Attachment #9054561 - Flags: approval-mozilla-beta?

Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto

New telemetry probes for a beta experiment, uplift approved for 67 beta 8, thanks.

Attachment #9054039 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attachment #9054561 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
You need to log in before you can comment on or make changes to this bug.