Collect Telemetry on process priority switching
Categories
(Core :: DOM: Content Processes, enhancement)
Tracking
()
People
(Reporter: mconley, Assigned: mconley)
References
Details
Attachments
(3 files)
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
2.66 KB,
text/plain
|
tdsmith
:
data-review+
|
Details |
47 bytes,
text/x-phabricator-request
|
pascalc
:
approval-mozilla-beta+
|
Details | Review |
We'd like to collect a count of how many times:
- We lower a process priority from normal to something else
- We bring a process priority back to normal
Comment 1•6 years ago
|
||
Edited to
- We lower a process priority from normal to something else
- We bring a process priority back to normal
- Total opportunities to change process priority (which in my head is equivalent to opening or switching tabs, correct me if i'm wrong)
Assignee | ||
Comment 2•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Assignee | ||
Comment 3•6 years ago
|
||
Assignee | ||
Updated•6 years ago
|
Comment 4•6 years ago
|
||
(In reply to "Saptarshi Guha[:joy]" from comment #1)
- Total opportunities to change process priority (which in my head is equivalent to opening or switching tabs, correct me if i'm wrong)
Yep, but also bringing a Firefox window up after having sent it into the background, etc...
Comment 5•6 years ago
|
||
Comment 6•6 years ago
|
||
Assignee | ||
Comment 7•6 years ago
|
||
Thanks for the reviews!
I made the mistake of auto-landing before I put tdsmith's name in the commit message, so it says data-review=chutten, but it should say data-review=tdsmith. Sorry about that!
Comment 9•6 years ago
|
||
bugherder |
Assignee | ||
Comment 10•6 years ago
|
||
Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: None really, but it might delay the roll out of the Process Priority Manager feature for Windows because our data science team won't be able to validate it's behaviour.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): These are just some telemetry probes to help with an experiment we want to run on Beta.
- String changes made/needed:
Assignee | ||
Comment 11•6 years ago
|
||
Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto
Dropping this - I've noticed a small issue with the probe where we'll increment the os_priority_raised probe every time we create a new tab. Investigating.
Assignee | ||
Comment 12•6 years ago
|
||
Re-opening this bug because I have a follow-up.
Assignee | ||
Comment 13•6 years ago
|
||
Updated•6 years ago
|
Comment 14•6 years ago
|
||
Comment 15•6 years ago
|
||
bugherder |
Assignee | ||
Comment 16•6 years ago
|
||
Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto
Beta/Release Uplift Approval Request
- Feature/Bug causing the regression: None
- User impact if declined: None really, but it might delay the roll out of the Process Priority Manager feature for Windows because our data science team won't be able to validate it's behaviour.
- Is this code covered by automated tests?: No
- Has the fix been verified in Nightly?: Yes
- Needs manual test from QE?: No
- If yes, steps to reproduce:
- List of other uplifts needed: None
- Risk to taking this patch: Low
- Why is the change risky/not risky? (and alternatives if risky): These are just some telemetry probes to help with an experiment we want to run on Beta.
- String changes made/needed: None
- Do you want to request approval of these patches as well?: on
Assignee | ||
Comment 17•6 years ago
|
||
Comment on attachment 9054561 [details]
Bug 1538987 - Follow-up: skip incrementing the DOM_CONTENTPROCESS_OS_PRIORITY_RAISED probe for the initialization case. r?gsvelto
See above.
Comment 18•6 years ago
|
||
Comment on attachment 9054039 [details]
Bug 1538987 - Collect Telemetry on process priority switching. data-review=chutten, r?gsvelto
New telemetry probes for a beta experiment, uplift approved for 67 beta 8, thanks.
Updated•6 years ago
|
Updated•6 years ago
|
Comment 19•6 years ago
|
||
bugherder uplift |
Description
•