Closed Bug 1539030 Opened 8 months ago Closed 7 months ago

Don't call RDDProcessManager::CreateContentBridge unless a new process is actually launched

Categories

(Core :: Audio/Video: Playback, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
mozilla68
Tracking Status
firefox68 --- fixed

People

(Reporter: mjf, Assigned: mjf)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

We're calling RDDProcessManager::CreateContentBridge even if we've already launched the RDD processs which is causing churn by recreating RemoteDecoderManagerParents.

I'm hoping this is the cause of Bug 1535335, but I'm not certain. I want to land this fix and watch the crash stats.

Assignee: nobody → mfroman
Rank: 10
Priority: -- → P2

We were calling RDDProcessManager::CreateContentBridge even if we'd
already launched the RDD process.

Blocks: RDD
Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a0bed49e8b10
Don't RDDProcessManager::CreateContentBridge unless needed. r=jya
Status: NEW → RESOLVED
Closed: 8 months ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla68
Depends on: 1540587
No longer depends on: 1540587
Regressions: 1540587

When I fixed 1540587, the fix was backing out the changes made in this bug completely. I have a more complete fix now so I'm going to reopen this bug.

Status: RESOLVED → REOPENED
Resolution: FIXED → ---

Detect content process that already has connection to the RDD process
and don't attempt to relaunch or needlessly call
RDDProcessManager::CreateContentBridge. Calling CreateContentBridge
unnecessarily causes churn by recreating RemoteDecoderManagerParents.

Pushed by mfroman@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/6638560366c4
(redux) don't attempt RDD launch unless needed. r=jya
Status: REOPENED → RESOLVED
Closed: 8 months ago7 months ago
Resolution: --- → FIXED

Comment on attachment 9061011 [details]
Bug 1539030 - (redux) don't attempt RDD launch unless needed. r?jya

Beta/Release Uplift Approval Request

  • User impact if declined: This patch reduces RDD initialization churn that could result in content process crash resembling Bug 1535335.
  • Is this code covered by automated tests?: No
  • Has the fix been verified in Nightly?: Yes
  • Needs manual test from QE?: No
  • If yes, steps to reproduce:
  • List of other uplifts needed: None
  • Risk to taking this patch: Low
  • Why is the change risky/not risky? (and alternatives if risky): Small changes in RemoteDecoderModule.{h|cpp} that only affect RDD re-initialization make this low risk.
  • String changes made/needed: n/a
Attachment #9061011 - Flags: approval-mozilla-beta?

Comment on attachment 9061011 [details]
Bug 1539030 - (redux) don't attempt RDD launch unless needed. r?jya

Fix a P2 but has no bake time on nightly and the volume of crashes it may fix is low. Given that we have already shipped our last beta, I think the risk is bigger than the potential reward so I am not taking the uplift, sorry.

Attachment #9061011 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.