1539199 - Pasting an item and pressing escape, then re-pasting can lead to the results popup not displaying on QuantumBar

Status: RESOLVED FIXED

(Firefox :: Address Bar, defect, P3)

Description

[Mark Banner (:standard8)]

STR

1. Enable QuantumBar
2. Restart Firefox
3. Create a new tab
4. Paste in "fkfkgkh"

=> The results popup is shown.

5. Press escape (popup closes)
6. Press escape a second time (text is cleared)
7. Paste again

=> The results popup is not shown.

At this stage, pressing escape and pasting again will never show the popup until the value is changed.

Note: if in step 4 the value pasted shows autofill, then there's an extra escape/paste cycle until you hit the popup not showing.

Comment 1

[Mark Banner (:standard8)]

Interestingly AwesomeBar exhibits the same issue. Though when in the broken state, if you press escape twice, it'll show the results popup again for one cycle.

I discovered this because the updated test for bug 1531693 fails with AwesomeBar.

Comment 2

[Drew Willcoxon :adw]

This looks related to how we bail out early in _on_input when the new search is the same as the previous search. When I remove the early return here, the problem goes away: https://searchfox.org/mozilla-central/rev/d302c3058330a57f238be4062fddea629311ce66/browser/components/urlbar/UrlbarInput.jsm#1329

I'll probably remove that bailout in bug 1541921, which would also fix this bug.

Comment 3

[Drew Willcoxon :adw]

Fixed by bug 1541921.