Closed Bug 1541921 Opened 5 months ago Closed 4 months ago

Quantum Bar: When typing a letter and deleting it immediately again makes the visited pages quick access Drop Down appear

Categories

(Firefox :: Address Bar, defect, P3)

defect
Points:
3

Tracking

()

VERIFIED FIXED
Firefox 68
Iteration:
68.3 - Apr 15 - 28
Tracking Status
firefox68 --- verified

People

(Reporter: mehmet.sahin, Assigned: adw)

References

Details

Attachments

(2 files)

Attached video screencast.mov

Firefox Nightly 68.0a1 (2019-04-04) (64-Bit)
MacOS 10.14.4 - but probably OS=ALL_Desktop

STR:

1.) Enable Quantum Bar or be in the Experiment
2.) Visit some pages so that the arrow down button (visited pages quick access button?) includes links
3.) Now focus the Address Bar and type one letter and immediately delete this letter again

Actual: The arrow down button (visited pages quick access button?) is activated and the Drop Down with the visited links appears

Expected: It should not appear. It should only appear when you click on the Arrow Down button

A screencast is attached.

Thanks.

it looks like a race condition the popup opens for the "a" search but it actually searches for "".

Points: --- → 3
Priority: -- → P3
Assignee: nobody → adw
Iteration: --- → 68.3 - Apr 15 - 28

We need to reset _lastSearchString in _on_input when the user backspaces over the last char. There are a couple of problems in this bug. The first is that the popup doesn't open and a new search doesn't start when you type the same char for the second time, after having backspaced over it. That's because you hit the same-search early return in _on_input because _lastSearchString hasn't been updated by that point. It's still the old value, the single char. The second problem follows from the first, and it's that when you then backspace over the char, the history popup opens because view.isOpen is false, so the early return in _on_input that checks for an empty search string (and open view) is not hit, and we continue on to do an empty search.

Blocks: 1539199
Attachment #9058876 - Attachment description: Bug 1541921 - Reset _lastSearchString when backspacing over the last char. → Bug 1541921 - Remove duplicate-search bailout from quantumbar.
Pushed by dwillcoxon@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b97df75c9365
Remove duplicate-search bailout from quantumbar. r=dao

I have no idea how this simple patch causes an ASAN failure. It didn't happen on try, but I rebased on the current tree before landing. Another try push:

https://treeherder.mozilla.org/#/jobs?repo=try&revision=de1d079ff28d23187dbeea87d5edec723289ab7d

Flags: needinfo?(adw)
Status: NEW → ASSIGNED

Oh, maybe it's not actually an ASAN problem, and instead Firefox just wouldn't shut down, so this terminated it (with an intentional segfault?): https://searchfox.org/mozilla-central/source/toolkit/components/terminator/nsTerminator.cpp

Failing on try now too. Maybe it's the new test, although it must be in conjunction with something else since I last updated my tree. And I doubt it since it's not in the failing logs. But anyway, without it: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6519d6ed172d8b49ac7f65cbf956d1d93b13ff6d

I haven't been able to figure this out today. I'm starting to think something is wrong with bug 1522278's fix, especially after bug 1545731 was filed, and this bug somehow exposed it. But I'm not sure. Here's a try push reverting that bug and with the patch to this bug applied: https://treeherder.mozilla.org/#/jobs?repo=try&revision=c00a452492fda185835e6aea46014b801fcfc819

I tried bisecting mozilla-central with the patch applied and pushing to try to see which revision caused the difference between before I refreshed my tree and after. Long story short, other failures introduced in various revisions and subsequent backouts made that hard to do, but I found a revision, but it doesn't make much sense because it has to do with Servo layout. So I'm not very confident about it.

As a sanity check, I refreshed my tree tonight and pushed the patch to try again, and there's no problem: https://treeherder.mozilla.org/#/jobs?repo=try&revision=ebf062666325f31b60330ba37d8ab94a98ab6c56

So I'm just going to land this again.

Pushed by btara@mozilla.com:
https://hg.mozilla.org/mozilla-central/rev/cd4bab29d164
Remove duplicate-search bailout from quantumbar. r=dao
Status: ASSIGNED → RESOLVED
Closed: 4 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 68
Flags: qe-verify+
QA Contact: cristian.comorasu

Hello,
Reproduced the issue using Firefox 68.0a1 (20190404215521) on Windows 10 x64 and macOs 10.14.
The issue is verified fixed using Firefox 68.0b13 (20190624133534) and Firefox 69.0a1 on Windows 10x64, macOS 10.14, Ubuntu 18.04.

Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.